-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for case-insensitive matches #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the case flag an options bag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate_matcher is going to significantly suffer here. It will be unable to generate matchers for case insensitive parts
thats a problem, but i dont think there is much we can do (I'd be happily proven wrong) |
@crowlKats @lucacasonato - Any chance that this might land in Deno? According to https://developer.mozilla.org/en-US/docs/Web/API/URLPattern#browser_compatibility Deno has everything else implemented according to the spec except for the |
# Conflicts: # src/component.rs # src/quirks.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implements whatwg/urlpattern#168
Closes #12