Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gamepad plugin #82

Merged
merged 6 commits into from
Dec 20, 2023
Merged

New gamepad plugin #82

merged 6 commits into from
Dec 20, 2023

Conversation

Shaobin-Jiang
Copy link
Contributor

Using gamepads in experiments is sometimes needed, and while most browsers support it, a certain tweaking around is still needed. This plugin handles input from a gamepad and displays a minature model on the page that reflects user input in real time for the convenience of debugging.

Copy link

changeset-bot bot commented Dec 5, 2023

⚠️ No Changeset found

Latest commit: 608f5f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@jodeleeuw jodeleeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Shaobin-Jiang!

I left one small tweak to make to get the plugin to publish in the correct npm location.

packages/plugin-gamepad/package.json Outdated Show resolved Hide resolved
@jodeleeuw jodeleeuw merged commit 95c0797 into jspsych:main Dec 20, 2023
2 checks passed
@jodeleeuw
Copy link
Member

Thank you @Shaobin-Jiang !

@jodeleeuw
Copy link
Member

Reverted this because I missed the lack of a changeset. Will fix.

@jodeleeuw
Copy link
Member

Sorry @Shaobin-Jiang -- can you make a new PR? I should've checked more carefully first and just added the changeset as a separate commit. Can you also target @jspsych/config v2 in package.json?

@bjoluc
Copy link
Member

bjoluc commented Dec 20, 2023

@jodeleeuw Technically, we can also add a changeset for a specific PR after merging it thanks to changesets/changesets#535 👍

@jodeleeuw
Copy link
Member

oops. good to know, thank you!

Shaobin-Jiang added a commit to Shaobin-Jiang/jspsych-contrib that referenced this pull request Dec 21, 2023
@Shaobin-Jiang
Copy link
Contributor Author

@jodeleeuw Done in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants