Add function for flipping coherent dots in a trial #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f7655f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Anyone can review this? |
|
Do I need to make new plugin? @jodeleeuw |
|
@jadeddelta if you have a chance to look at this. I will try soon! |
jadeddelta
requested changes
Jan 11, 2025
.changeset/odd-laws-sleep.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@jspsych-contrib/plugin-rdk": patch | |||
There was a problem hiding this comment.
we should probably make this a minor version bump, patch is usually reserved for bug fixes and minor is reserved for backwards-compatible feature releases like this
There was a problem hiding this comment.
I've changed the version bump from patch into minor
jadeddelta
approved these changes
Jan 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves PLUGIN-RDK and adds a function that flip the direction of coherent dots.
You can change the direction of moving dots oppositely during a trial as many times as you want.
Information about added parameter follows below:
Name: flip_timestamps
Type: Array
Default: []
This function is similar one implemented in this study, where dots' directions are flipped probabilistically.
https://elifesciences.org/articles/08825
How to verify
please
cd plugin-rdk,npm iandnpm run build.I modified
example1.htmlso you can check how it works.Thank you in advance!