Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of on_page_change #3355

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Shaobin-Jiang
Copy link
Contributor

See discussion.

What this PR does:

  • on_page_change is called once at trial start
  • current_page is null if on_page_change is called at trial end
  • on_page_change receives second paramter from_page
    • from_page is the index of the page the subject was viewing
    • from_page is null if on_page_change is called at trial start

- on_page_change is called once at trial start
- current_page is null if on_page_change is called at trial end
- on_page_change receives second paramter from_page
  - from_page is the index of the page from which the current page is
    switched to
  - from_page is null if on_page_change is called at trial start
Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: 793b09b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@jspsych/plugin-instructions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant