Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a local release of the reference checker #189

Merged
merged 15 commits into from
Jul 25, 2024
Merged

Conversation

wmdietl
Copy link
Collaborator

@wmdietl wmdietl commented Jul 15, 2024

Contains the changes from #188, merge that first.

This can already be used to run ./gradlew PublishToMavenLocal and allows local usage.
The new directory usage-demo contains a working example that depends on the local release.

build.gradle Outdated Show resolved Hide resolved
Until the JSpecify Reference Checker is released to Maven Central, on must first run:

````
./gradlew PublishToMavenLocal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have guessed that this command would need to use .. and the one on line 14 would need to use .. I haven't tested that theory, but does that sound right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the number of dots is correct. I added more explanations to hopefully make it clearer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you, that completely clarified things for me.

usage-demo/build.gradle Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Until the JSpecify Reference Checker is released to Maven Central, on must first run:

````
./gradlew PublishToMavenLocal
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the number of dots is correct. I added more explanations to hopefully make it clearer.

@wmdietl wmdietl changed the title Make a release of the reference checker Make a local release of the reference checker Jul 25, 2024
@wmdietl wmdietl merged commit af9dfbc into main-eisop Jul 25, 2024
3 of 5 checks passed
@wmdietl wmdietl deleted the release-checker branch July 25, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants