Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EISOP release and include jspecify/jdk in jar #188

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

wmdietl
Copy link
Collaborator

@wmdietl wmdietl commented Jul 15, 2024

To test, include the changes from #178 and #186:

git clone https://github.com/jspecify/jspecify-reference-checker -b use-eisop-release
cd jspecify-reference-checker
git pull origin detailed-diagnostics --no-rebase
git pull origin issue-177 --no-rebase
./gradlew test conformanceTests

Everything should pass. The Basic.java conformance test would fail if it would not use jspecify/jdk.

I haven't tried including local checker-framework and jspecify clones, but would hope that that works as expected.

I'm trying to make a reference checker release and include it in a separate build, but will do that in a separate PR.

@wmdietl wmdietl merged commit 36855b8 into main-eisop Jul 25, 2024
3 of 5 checks passed
@wmdietl wmdietl deleted the use-eisop-release branch July 25, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants