Skip to content

Conversation

@dai-shi
Copy link
Contributor

@dai-shi dai-shi commented Jun 7, 2023

Add proxy-memoize

Add proxy-memoize
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account error The page requested returns an error labels Jun 7, 2023
@indus
Copy link
Member

indus commented Jun 7, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But I'm getting a redirect error. This may be result of a incorrect workflow. Could you try to remove and re-add the CANME (maybe by using the repo settings).

It lookssimilar to #8284 where we had the same error for a page that used a workflow to deploy (@MattIPv4 🤷‍♂️)

@dai-shi
Copy link
Contributor Author

dai-shi commented Jun 7, 2023

I'm trying but still no luck yet.

@MattIPv4
Copy link
Member

MattIPv4 commented Jun 7, 2023

Yeah -- I wonder if something has changed on GitHub's end. I imagine someone just needs to reach out to support to see what they say.

@indus
Copy link
Member

indus commented Jun 8, 2023

@dai-shi would you mind to open a support ticket?

@dai-shi
Copy link
Contributor Author

dai-shi commented Jun 8, 2023

Done!

@dai-shi
Copy link
Contributor Author

dai-shi commented Jun 10, 2023

Here's a response from GitHub support.

It looks like you've set up your domain's DNS with Cloudflare. Cloudflare enables their HTTP/DNS proxy feature by default, meaning GitHub isn't able to see the DNS records required to generate an HTTPS certificate. You'll need to disable this for any DNS records that point towards GitHub.

Disclaimer: Disabling the HTTP/DNS proxy may interfere with other Cloudflare services. If you use other Cloudflare services with your site, we aren't able to guarantee that these will continue working. For more help with this, I'd recommend reaching out to Cloudflare's support team.

If you'd still like to continue, you can follow the instructions below:
...

@MattIPv4
Copy link
Member

Yikes, why are they suddenly requiring the proxy be disabled... that seems wrong.

I would push back and say that the Cloudflare proxy normally works just fine for GitHub Pages, and it seems like an issue on their end that it isn't working now suddenly -- we don't expect/need them to generate an HTTPS certificate, Cloudflare handles that.

@MattIPv4
Copy link
Member

Feel free to CC me in if you want: [email protected] should work

@indus
Copy link
Member

indus commented Jun 10, 2023

@dai-shi just one question besides the gh support thing: Have you checked the "Enforce HTTPS" option in you repo settings?
image
By default it is unchecked but enabling it could be a reason for the issue as well I guess...

@dai-shi
Copy link
Contributor Author

dai-shi commented Jun 10, 2023

It is checked by default, and can't be unchecked.
image

@indus
Copy link
Member

indus commented Jun 10, 2023 via email

@dai-shi
Copy link
Contributor Author

dai-shi commented Jun 10, 2023

Well, without custom domain I still can't uncheck it...

image

@dai-shi
Copy link
Contributor Author

dai-shi commented Jun 10, 2023

Good news. I was able to uncheck "Enforce SSL" with changing the source to Deploy from a branch. And, then changing it back to GitHub Actions while keeping the option unchecked. Now, the infinite redirect is gone.

image

@indus
Copy link
Member

indus commented Jun 10, 2023 via email

@indus indus removed the error The page requested returns an error label Jun 11, 2023
@indus
Copy link
Member

indus commented Jun 11, 2023

Welcome https://proxy-memoize.js.org

@indus indus merged commit 96abdef into js-org:master Jun 11, 2023
@indus indus mentioned this pull request Jun 11, 2023
2 tasks
@dai-shi dai-shi deleted the patch-1 branch June 11, 2023 22:52
@indus indus mentioned this pull request Aug 1, 2023
2 tasks
@indus indus mentioned this pull request Sep 16, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants