feat: website #69

Aslemammad · 2023-05-01T16:49:03Z

The Proxy Memoize website. Built with Astro, unocss and mostly vanilla javascript.

codesandbox-ci · 2023-05-01T16:49:22Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de68e15:

Sandbox	Source
Vanilla	Configuration
Vanilla Typescript	Configuration
React	Configuration
React Typescript	Configuration

Aslemammad · 2023-05-01T16:53:51Z

@dai-shi Is the CI enabled for new workflows, we'd like to add the github pages.

dai-shi · 2023-05-01T21:38:38Z

@dai-shi Is the CI enabled for new workflows, we'd like to add the github pages.

CI is enabled. You mean another workflow for github pages?

btw, if we go with github pages, we can apply for proxy-memoize.js.org.

Aslemammad · 2023-05-01T22:46:09Z

CI is enabled. You mean another workflow for github pages?

Yes

btw, if we go with github pages, we can apply for proxy-memoize.js.org.

That'd be good actually, but how about the github one? As far as I know they used to give free domains for github pages.

dai-shi · 2023-05-01T23:12:16Z

Can you check the workflow file? Doesn't seem to work?

As far as I know they used to give free domains for github pages.

I didn't know about it. Never used before.

Aslemammad · 2023-05-02T03:43:43Z

I didn't know about it. Never used before.

Let's use it and see, we'll let you know.

Can you check the workflow file? Doesn't seem to work?

@Sajad-Sharhani

Aslemammad · 2023-05-02T03:44:16Z

website/astro.config.mjs

+export default defineConfig({
+  // setup for github pages
+  site: 'https://pheno-agency.github.io',
+  base: '/proxy-memoize',


@Sajad-Sharhani I think the base should be /website, it's the directory that the site lives in. And please add the github workflow that astro recommends.

Aslemammad · 2023-05-03T06:43:31Z

website/src/components/Navbar.astro

+  <head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+  </head>


@Morteza-Mazrae I guess you need to remove the whole head here cause we already have it in the layout.

Aslemammad · 2023-05-03T06:43:43Z

website/src/components/Sidebar.astro

+  <head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+  </head>


@Morteza-Mazrae also here

Aslemammad · 2023-05-03T06:44:17Z

website/src/pages/index.astro

@@ -16,6 +17,9 @@ const docs = await Astro.glob('../../../docs/**/*.md');
 		<title>Proxy Memoize</title>


@Morteza-Mazrae move these stuff to the layout (the head section, they all should be in one place)

…into feat/website

Aslemammad · 2023-05-03T13:54:27Z

website/src/components/Mainhero.astro

+  <head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+  </head>


@Jawad-sawari this head thing should be removed, we don't need them, it's not logical.

@Morteza-Mazrae I don't think in astro components we bring and

only the elements we need, in case of this file, the
only we need.

@Aslemammad I removed the whole extra head tags

…t/website

Aslemammad · 2023-06-04T13:03:53Z

Hey @dai-shi we've been able to finish the website, now you can take a look and see! Let us know, it's been a fun experience.

Aslemammad · 2023-06-04T13:09:03Z

https://pheno-agency.github.io/proxy-memoize/

Here's the lighthouse score:

We've been able to keep most of the site static and keep some level of interactivity at the same time so we can achieve such a lighthouse result. Only one component is written in react and all of the rest are in astro (simple html with some script tags)

dai-shi

Thanks for your work!!!
Some comments added. I would like to see it deployed on GitHub pages?

dai-shi · 2023-06-06T04:46:52Z

.github/workflows/deploy.yml

+  # Trigger the workflow every time you push to the `main` branch
+  # Using a different branch name? Replace `main` with your branch’s name
+  push:
+    branches: [feat/website]


Does this work now in this branch?

Yes, but since it's a fork, it pushes in our repo, when merged, it should be changed to main. You can see the link here for instance https://pheno-agency.github.io/proxy-memoize/

Hm, okay, let's change it to main in this PR and we will see.

sure, cc @Sajad-Sharhani

dai-shi · 2023-06-06T04:46:55Z

.pnpm-debug.log

@@ -0,0 +1,23 @@
+{


Please remove this file.

dai-shi · 2023-06-06T04:47:09Z

.vscode/settings.json

@@ -0,0 +1,2 @@
+{


Please remove this file.

website/package.json

Co-authored-by: Daishi Kato <[email protected]>

…into feat/website

website/src/env.d.ts

dai-shi · 2023-06-06T12:38:54Z

Can you please check the CI error?

dai-shi

Thanks for your wonderful work! Let's merge.

dai-shi · 2023-06-07T14:29:44Z

Hi, I'm trying to deploy it as proxy-memoize.js.org, but having a trouble.
js-org/js.org#8294

I'm not sure how it's caused, but if you guys know something, it's helpful.

Aslemammad · 2023-06-07T21:04:35Z

As I see it's an issue with github pages and not proxy memoize, am I right?

Sajad-Sharhani · 2023-06-07T21:24:01Z

Can u first deploy it on github pages subdomain?
To understand where is the problem exactly.

dai-shi · 2023-06-08T00:19:48Z

Can u first deploy it on github pages subdomain?

Yes, it was perfectly fine!

As I see it's an issue with github pages and not proxy memoize, am I right?

Yeah, seems like so...

Aslemammad · 2023-06-08T02:56:22Z

Yeah, seems like so...

I think you'd be able to issue a ticket to the github support so they know the issue (as others also had it), otherwise, I guess we need to go the plain github pages way or buy our own domain! or move things to vercel (which takes time, since we need to change the assets base from /proxy-memoize/ to / in astro)

dai-shi · 2023-06-08T04:06:36Z

fwiw, I never had such an issue with gh-pages branch.
for example this one:
https://github.com/dai-shi/remote-faces/blob/0ffe195510db6803540da8bd92196f4f6211c26b/.github/workflows/cd.yml#L44
(but I haven't deployed it recently.)

Aslemammad · 2023-06-08T04:36:47Z

maybe it's because of the CNAME file?

dai-shi · 2023-06-10T22:56:03Z

The custom domain issue is resolved, but now I face the base path issue...
Looking at https://docs.astro.build/en/reference/configuration-reference/#base, I hope I didn't make any mistakes.

Aslemammad · 2023-06-11T06:05:39Z

@Sajad-Sharhani Hey Sajad, Daishi has been able to fix the custom domain issue, can you change the assets paths and fix the issue?

Here's the new url https://proxy-memoize.js.org/

init

dd714d6

Sajad-Sharhani added 2 commits May 1, 2023 23:18

github pages

91f78ae

update

1cc30ff

update

2235359

Aslemammad commented May 2, 2023

View reviewed changes

Morteza-Mazrae added 2 commits May 2, 2023 16:18

layout

ca51b44

toggle theme

1c33682

Aslemammad commented May 3, 2023

View reviewed changes

Jawad-sawari and others added 4 commits May 3, 2023 14:14

hero section

fc343d4

Merge branch 'feat/website' of github.com:Pheno-agency/proxy-memoize …

071eda5

…into feat/website

sidebar items

9074c54

Merge branch 'feat/website' of github.com:Pheno-agency/proxy-memoize …

f6840a9

…into feat/website

Aslemammad commented May 3, 2023

View reviewed changes

Morteza-Mazrae and others added 9 commits May 3, 2023 18:57

sidebar

293fd5d

removing extra head tags

d146162

update

319fa99

update pnpm

028a917

update pnpm 0

0e81651

main hero responsive

91a43cc

main hero dark mode

719dd39

Merge branch 'main' of github.com:Pheno-agency/proxy-memoize into fea…

044ad9d

…t/website

Merge branch 'dai-shi:main' into feat/website

45748e3

Jawad-sawari added 5 commits June 3, 2023 16:44

main hero assets

6de422a

content margin-top

6be6898

format document

4b06743

Deleted the file from the git repository

ee92045

main hero asset

3614658

Aslemammad marked this pull request as ready for review June 4, 2023 13:01

dai-shi reviewed Jun 6, 2023

View reviewed changes

Aslemammad and others added 4 commits June 6, 2023 10:27

Update website/package.json

9ba85b2

Co-authored-by: Daishi Kato <[email protected]>

deploy update

94dd934

delete pnpm debug

fd1370b

Merge branch 'feat/website' of github.com:Pheno-agency/proxy-memoize …

1f11efe

…into feat/website

dai-shi reviewed Jun 6, 2023

View reviewed changes

website/src/env.d.ts Outdated Show resolved Hide resolved

Update website/src/env.d.ts

0b8092a

Sajad-Sharhani added 2 commits June 6, 2023 15:42

lint update

4baad63

lint update

de68e15

dai-shi approved these changes Jun 7, 2023

View reviewed changes

dai-shi merged commit 2ddd4a6 into dai-shi:main Jun 7, 2023

Aslemammad deleted the feat/website branch June 7, 2023 06:57

		@@ -16,6 +17,9 @@ const docs = await Astro.glob('../../../docs/*/.md');
		<title>Proxy Memoize</title>

Uh oh!

feat: website #69

feat: website #69

Uh oh!

Conversation

Aslemammad commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci bot commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aslemammad commented May 1, 2023

Uh oh!

dai-shi commented May 1, 2023

Uh oh!

Aslemammad commented May 1, 2023

Uh oh!

dai-shi commented May 1, 2023

Uh oh!

Aslemammad commented May 2, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aslemammad commented Jun 4, 2023

Uh oh!

Aslemammad commented Jun 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dai-shi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dai-shi Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dai-shi commented Jun 6, 2023

Uh oh!

dai-shi left a comment

Choose a reason for hiding this comment

Uh oh!

dai-shi commented Jun 7, 2023

Uh oh!

Aslemammad commented Jun 7, 2023

Uh oh!

Sajad-Sharhani commented Jun 7, 2023

Uh oh!

dai-shi commented Jun 8, 2023

Uh oh!

Aslemammad commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dai-shi commented Jun 8, 2023

Uh oh!

Aslemammad commented Jun 8, 2023

Uh oh!

dai-shi commented Jun 10, 2023

Aslemammad commented May 1, 2023 •

edited

Loading

codesandbox-ci bot commented May 1, 2023 •

edited

Loading

Aslemammad commented Jun 4, 2023 •

edited

Loading

dai-shi Jun 6, 2023 •

edited

Loading

Aslemammad commented Jun 8, 2023 •

edited

Loading