-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parsers] URDF and YAML generation from ParserResult #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok (I haven't looked very carefully at the conversion code itself but I'm assuming the tests cover it well)
I'd like to see a few changes:
- Factor the testing code for comparing
ParserResult
instances and generating the examples since they are basically the same between each tests - I don't like that you need to have
transformInertia = false
with the generated files, you can get an inertia that will transform correctly by callingsva::inertiaToOrigin(inertia, -mass, com, Eigen::Matrix3d::Identity())
. The only information that is definitely lost is the inertial frame orientation that could be in the original URDF.
Ok no problem
I don't like it either so I'll try what you suggest and see if it works properly |
Ok, so the parser tests refactoring is done and |
The generated URDF/YAML models must be read with transformInertia = false becausethere is no way to recover the original rotation from the available data
Thanks for your contribution @BenjaminNavarro |
Unless I'm missing something, the generated URDF/YAML models must be later read with
transformInertia = false
because there is no way to recover the original rotation from the available data. I don't know if it is a big issue or if we can find a workaround for this