Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-built version of jquery-ui #2011

Closed
MattIPv4 opened this issue Nov 9, 2021 · 12 comments · Fixed by #2059
Closed

Pre-built version of jquery-ui #2011

MattIPv4 opened this issue Nov 9, 2021 · 12 comments · Fixed by #2059

Comments

@MattIPv4
Copy link

MattIPv4 commented Nov 9, 2021

Hey folks,

We're trying to update jquery-ui on cdnjs, but it looks like this repo as well as the NPM package only distribute jquery-ui in its assorted parts, rather than shipping a pre-built JS bundle like you get if you use the code.jquery.com CDN or the download option on the site.

Is there a distributed version that is pre-built available in an NPM package or tagged git repository anywhere that we can use as the update target for cdnjs? Or, should we just be hosting the content of UI & themes from the NPM package / git repo on the CDN?

Cheers, Matt.

(cc cdnjs/packages#889)

@mgol
Copy link
Member

mgol commented Nov 15, 2021

Hey! We distribute the built files to CDNs and share zipped copies of the bundles on the jQuery UI sites. We're not planning any changes here as the project is mostly in maintenance mode.

You can download the full source & theme packages by using the quick download links from the jQuery UI Download Builder page or the 1.13 blog post.

I hope that's enough for you. Thanks!

@mgol mgol closed this as completed Nov 15, 2021
@MattIPv4
Copy link
Author

Unfortunately, downloading from the site won't work for cdnjs -- we either need the files in an NPM package, or in a tagged git repo.

Many users rely on jQuery UI through cdnjs, so it'd be great if y'all could help out here so that we can get the updated version made available to them :)

@mgol
Copy link
Member

mgol commented Nov 15, 2021

How do you handle older jQuery UI versions? I think none of them includes built files, don't they?

@MattIPv4
Copy link
Author

Looking at our config, we've never updated this library under the new system -- under the old system folks would manually commit files but we no longer permit that for an assortment of reasons (mainly security + infra).

@glensc
Copy link

glensc commented Nov 15, 2021

you could perhaps create a branch or tag (jquery-ui-1.13.0.cdn) and put built files there for cdnjs...

@umer936
Copy link

umer936 commented Feb 2, 2022

Any chance this is going to happen?

@mgol
Copy link
Member

mgol commented Feb 2, 2022

Alright, it might be that it's just a question of copying two files from the dist/cdn folder before this line in the release script and then committing them. Since cdnjs is not able to consume what we have right now, let me try this.

If this works (I still need to try it), we could release it as 1.13.2 when it arrives.

(please don't assume it will happen just yet, I am not 100% sure yet if this works)

@mgol mgol reopened this Feb 2, 2022
@mgol mgol self-assigned this Feb 2, 2022
@mgol mgol added this to the 1.13.2 milestone Feb 2, 2022
mgol added a commit to mgol/jquery-ui that referenced this issue Mar 2, 2022
Both unminified & minified versions are included.

Fixes jquerygh-2011
mgol added a commit to mgol/jquery-ui that referenced this issue Mar 4, 2022
Both unminified & minified versions are included.

Fixes jquerygh-2011
mgol added a commit to mgol/jquery-ui that referenced this issue Mar 4, 2022
Both unminified & minified versions are included.

Fixes jquerygh-2011
mgol added a commit to mgol/jquery-ui that referenced this issue Mar 4, 2022
Both unminified & minified versions are included.

Fixes jquerygh-2011
mgol added a commit to mgol/jquery-ui that referenced this issue Mar 4, 2022
Both unminified & minified versions of JS & CSS files are included, for all
themes, as well as images.

Fixes jquerygh-2011
@mgol
Copy link
Member

mgol commented Mar 4, 2022

PR: #2059

@mgol
Copy link
Member

mgol commented Mar 4, 2022

@MattIPv4 It might be helpful for you to review the above PR as well. This currently adds everything that gets published to the CDN to the dist folder. As an example, if this was included in the 1.13.1 release then dist in the npm package would contain everything from https://github.com/jquery/codeorigin.jquery.com/tree/main/cdn/ui/1.13.1, maintaining the directory structure. This matters as the CSS files refer to relative image paths, e.g. https://code.jquery.com/ui/1.13.1/themes/base/jquery-ui.css includes url("images/ui-icons_444444_256x240.png") which refers to https://code.jquery.com/ui/1.13.1/themes/base/images/ui-icons_444444_256x240.png.

@MattIPv4
Copy link
Author

MattIPv4 commented Mar 5, 2022

👀 That looks/sounds great!

@MagnonD
Copy link

MagnonD commented Mar 7, 2022

Looks good to me too

mgol added a commit that referenced this issue Mar 23, 2022
Both unminified & minified versions of JS & CSS files are included, for all
themes, as well as images.

Fixes gh-2011
Closes gh-2059
@mgol
Copy link
Member

mgol commented Jul 18, 2022

This change went out in jQuery UI 1.13.2: https://blog.jqueryui.com/2022/07/jquery-ui-1-13-2-released/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants