-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: jqueryui to v1.13.0 #889
Comments
👋 It looks like both the jquery-ui GitHub repo & NPM package do not distribute the files you're referencing here, it appears that they only distribute the constituent parts. |
Thanks for looking into it and creating that issue for jquery-ui |
Going to close this out, the jQuery folks seem uninterested in publishing a version that is compatible with cdnjs. |
I already send a mail to the cloudflare service to update jquery-ui to 1.13.0 and they promised. There are changes which make it incompatible to Elfinder in Typesetter-CMS (before V 1.12.1) : Invalid jQuery UI configuration. |
I believe they have now publishing a version that is compatible with cdnjs in 1.13.1 |
It looks like they've merged the PR that should generate a version that can be used on cdnjs, but a new library version has not yet been published using that new release mechanic. The repo you link to (codeorigin) doesn't work for cdnjs as the directory changes each release, and the versions aren't tagged :) |
I am new to how these all link, or on the requirements for, but I thought the 1.13.1 was the new tag. |
Alas no, 1.13.1 was released before their fix for the NPM package was merged, so I imagine it'll work for 1.13.2. cdnjs needs either a GitHub repository with tags for each version, or an NPM package that is released for each version. In either case, we also expect the assets to be in a consistent location. The repo you linked doesn't have tags for each version, and it also has a changing directory where the assets are located. The fix that has been merged by the jquery-ui team though should result in the contents of each version within that repository essentially being included as part of each version on NPM, so that we have versioned assets at a consistent location (/dist within the NPM package). |
I don’t have time to create a full issue now but for whoever has time: we released jQuery UI 1.13.2 yesterday and it includes built files in the npm package so you should be able to use it. |
Library name
jqueryui
Library JSON file
https://github.com/cdnjs/packages/blob/master/packages/j/jqueryui.json
Library source
https://github.com/jquery/jquery-ui
Files to include
The text was updated successfully, but these errors were encountered: