Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: jqueryui to v1.13.0 #889

Closed
MagnonD opened this issue Nov 8, 2021 · 9 comments
Closed

Update: jqueryui to v1.13.0 #889

MagnonD opened this issue Nov 8, 2021 · 9 comments
Labels
📦 Update Request Request for an existing library on cdnjs to be updated

Comments

@MagnonD
Copy link

MagnonD commented Nov 8, 2021

Library name

jqueryui

Library JSON file

https://github.com/cdnjs/packages/blob/master/packages/j/jqueryui.json

Library source

https://github.com/jquery/jquery-ui

Files to include

  • jquery-ui.min.css
  • jquery-ui.min.js
  • jquery-ui.css
  • jquery-ui.js
@MagnonD MagnonD added the 📦 Update Request Request for an existing library on cdnjs to be updated label Nov 8, 2021
@MattIPv4
Copy link
Member

MattIPv4 commented Nov 9, 2021

👋 It looks like both the jquery-ui GitHub repo & NPM package do not distribute the files you're referencing here, it appears that they only distribute the constituent parts.

@MagnonD
Copy link
Author

MagnonD commented Nov 10, 2021

Thanks for looking into it and creating that issue for jquery-ui

@MattIPv4
Copy link
Member

Going to close this out, the jQuery folks seem uninterested in publishing a version that is compatible with cdnjs.

@gtbu
Copy link

gtbu commented Jan 20, 2022

I already send a mail to the cloudflare service to update jquery-ui to 1.13.0 and they promised.

There are changes which make it incompatible to Elfinder in Typesetter-CMS (before V 1.12.1) : Invalid jQuery UI configuration.
Selectable, draggable and droppable components must be included.

@MagnonD
Copy link
Author

MagnonD commented Mar 24, 2022

I believe they have now publishing a version that is compatible with cdnjs in 1.13.1
See https://github.com/jquery/codeorigin.jquery.com/tree/main/cdn/ui/1.13.1
(Or for the issue see jquery/jquery-ui#2011)

@MattIPv4
Copy link
Member

It looks like they've merged the PR that should generate a version that can be used on cdnjs, but a new library version has not yet been published using that new release mechanic.

The repo you link to (codeorigin) doesn't work for cdnjs as the directory changes each release, and the versions aren't tagged :)

@MagnonD
Copy link
Author

MagnonD commented Mar 28, 2022

I am new to how these all link, or on the requirements for, but I thought the 1.13.1 was the new tag.
Is the problem that the tag changing changes the directory?
So https://github.com/jquery/codeorigin.jquery.com/tree/main/cdn/ui/1.13.1 would change to .../1.13.x in future minor releases?

@MattIPv4
Copy link
Member

Alas no, 1.13.1 was released before their fix for the NPM package was merged, so I imagine it'll work for 1.13.2.

cdnjs needs either a GitHub repository with tags for each version, or an NPM package that is released for each version. In either case, we also expect the assets to be in a consistent location.

The repo you linked doesn't have tags for each version, and it also has a changing directory where the assets are located. The fix that has been merged by the jquery-ui team though should result in the contents of each version within that repository essentially being included as part of each version on NPM, so that we have versioned assets at a consistent location (/dist within the NPM package).

@mgol
Copy link

mgol commented Jul 15, 2022

I don’t have time to create a full issue now but for whoever has time: we released jQuery UI 1.13.2 yesterday and it includes built files in the npm package so you should be able to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Update Request Request for an existing library on cdnjs to be updated
Projects
None yet
Development

No branches or pull requests

4 participants