Skip to content
This repository has been archived by the owner on Dec 11, 2021. It is now read-only.

Colors: Initial pass on updated palette. #140

Closed
wants to merge 4 commits into from

Conversation

sfrisk
Copy link
Contributor

@sfrisk sfrisk commented Jan 26, 2016

Need to fix a spacing issue, but basic pass at the colors. A codepen illustrating this palette can be found at http://codepen.io/sfrisk/pen/bbeec265547b3554d047c445da957c1c/

@arschmitz
Copy link
Contributor

👍 the colors look good i like them. Remember for previews we have view.css-chassis.com all you need to do is push to a branch in the main repo instead of your fork

@sfrisk
Copy link
Contributor Author

sfrisk commented Jan 26, 2016

Yeah, it was more I didn't have a visual demo of these yet.

"text": {
name: "Text Colors",
value: {
"base": "#212121",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too light? maybe something darker like #111111 ?

@geekman-rohit
Copy link
Contributor

I think the colors are great. But they could be slightly darker to pass all WCAG tests.
I suggest the following:

  • The base colors should pass all tests
  • The lighter ones may be allowed to fail the AAA tests for normal size but must pass all other
  • Colors in palettes like primary, success to be checked as background, with a white foreground
  • We should have a demo page so we can run accessibility testing on all colors in palette

@cvrebert
Copy link
Contributor

Have y'all considered testing the distinguishability of the colors to people who are colorblind?

@arschmitz
Copy link
Contributor

@cvrebert more then thought about #114

@cvrebert
Copy link
Contributor

Ah, didn't know axe covered that. Neat.

@sfrisk
Copy link
Contributor Author

sfrisk commented Feb 16, 2016

Updated colors to reflect what is in the button PR. If that looks good, I'll merge it.

@sfrisk sfrisk closed this in 515abf2 Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants