This repository has been archived by the owner on Dec 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Colors: Initial pass on updated palette. #140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 the colors look good i like them. Remember for previews we have view.css-chassis.com all you need to do is push to a branch in the main repo instead of your fork |
Yeah, it was more I didn't have a visual demo of these yet. |
"text": { | ||
name: "Text Colors", | ||
value: { | ||
"base": "#212121", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too light? maybe something darker like #111111
?
I think the colors are great. But they could be slightly darker to pass all WCAG tests.
|
Have y'all considered testing the distinguishability of the colors to people who are colorblind? |
Ah, didn't know axe covered that. Neat. |
Updated colors to reflect what is in the button PR. If that looks good, I'll merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix a spacing issue, but basic pass at the colors. A codepen illustrating this palette can be found at http://codepen.io/sfrisk/pen/bbeec265547b3554d047c445da957c1c/