Build: add accessibility testing #114
Conversation
|
@dylanb feel free to force push PR's instead of opening new ones for the same thing. |
|
wooo hooo! Build passed. |
| @@ -0,0 +1,9 @@ | |||
| module.exports = { | |||
| firefox: { | |||
There was a problem hiding this comment.
Why only firefox? We do chrome and firefox for the performance testing id like to do the same here if possible
There was a problem hiding this comment.
Chrome does not work on Travis. I could add a chrome target for use locally.
There was a problem hiding this comment.
Could you please. We use browserstack for cross browser testing on travis. Can axe-webdriver use browserstack? We don't run the performance stuff on browserstack because browserstack is not consistent enough for performance testing.
There was a problem hiding this comment.
Adding chrome will crash travis ?. Maybe we could have two tests, one for travis and another with chrome to run locally.
| urls: ['http://localhost:4200/demos/typography.html'], | ||
| dest: 'tmp/gu.json' | ||
| }, | ||
| chrome: { |
There was a problem hiding this comment.
Didn't we want to remove chrome?
There was a problem hiding this comment.
why would we not want chrome?
There was a problem hiding this comment.
The travis will crash otherwise. We should have a separate test that uses chrome, that test will not be a part of travis.
There was a problem hiding this comment.
we should not be running this at all on travis directly it should be on browserstack.
|
@dylanb my comment got lost when you updated but can axe-webdriver run on browserstack? |
|
@arschmitz there is no reason it should not run on browserstack - I have never set it up to run there - how do the browserstack tests run for chassis? |
|
@dylanb there are none for chassis yet this is the first thing that would use it. Sorry i used "we" a bit ambiguously here it was more a general "jquery foundation" we. We have a browserstack account for all our CI cross browser testing so we should use that here as well. |
|
@arschmitz could we handle that as a separate issue? I will need some help getting browserstack set up. |
|
@dylanb thats fine if its not a part of axe-webdriver already its probably going to need to be done there first i can probably help with that. |
|
@arschmitz that would be really awesome! |
|
@arschmitz I have renamed the axe grunt Webdriver plugin to grunt-axe-webdriver and made the appropriate changes to this PR. What else do I need to do to get this merged? |
|
@arschmitz @dylanb |
|
@sfrisk I am waiting on feedback from someone as to what I need to do to make this mergeable...bit-rot has caused it to get out of sync with other code changes but I can fix that quite quickly |
|
Hey, @dylanb, I think this looks good (sorry about the late response), could you just merge latest master into this to make sure everything still runs? If it does, this PR should be good to go. |
|
@geekman-rohit I've been working on pulling it in, but there are some merge conflicts I need to deal with. |
Fixes #99