Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Oslash and oslash sidebearings #43

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Fix Oslash and oslash sidebearings #43

merged 1 commit into from
Feb 22, 2019

Conversation

m4rc1e
Copy link
Contributor

@m4rc1e m4rc1e commented Feb 19, 2019

Fixes google/fonts#1851

@jpt will get you some diffs

@jpt
Copy link
Owner

jpt commented Feb 20, 2019

Thanks @m4rc1e ! I tend to agree with #41 so this may change again soon

@m4rc1e
Copy link
Contributor Author

m4rc1e commented Feb 20, 2019

Np! For the time being we should merge this.

@m4rc1e
Copy link
Contributor Author

m4rc1e commented Feb 20, 2019

Here are the diffs I promised, Barlow-std_diffenator.zip.

Apart from the Oslash some other minor changes have occurred. These have been caused by Glyphsapp. Judging by the diff images and reports, they're not noticeable to the human eye. Please inspect the html report for each font to see for yourself.

If you're happy, please merge and I will push a new version to GF. I hope we can solve this by Friday.

Keep this open, just double checking.

@m4rc1e
Copy link
Contributor Author

m4rc1e commented Feb 20, 2019

Here are the diffs for the Condensed, barlow_condensed.zip and SemiCondensed,
barlow_semicondensed.zip

Let me know if you're happy and I'll push to GF once merged.

@jpt
Copy link
Owner

jpt commented Feb 21, 2019

Great, thanks @m4rc1e -- and understood on timeline; I'll take a look at the diffs in the morning.

@jpt jpt merged commit 5585dc9 into jpt:master Feb 22, 2019
@jpt
Copy link
Owner

jpt commented Feb 22, 2019

lgtm, thank you @m4rc1e !

@carnevalle
Copy link

Hi @jpt

This is still an issue
google/fonts#4055

@jpt
Copy link
Owner

jpt commented Nov 24, 2021

Thanks @carnevalle. I think it has been a few years since that alternate ø was included in a Barlow release, after a number of emails and issues created by Norwegian users.

There is an entirely re-spaced, re-kerned Barlow in the 1.5 branch (https://github.com/jpt/barlow/tree/1.5) that improves Barlow in a variety of other ways as well. I'm currently working on #10, but I could also bump up to a more incremental release. I'd have to take a look and see how it does with fontbakery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants