Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barlow Condensed: Extra space after character ø #1851

Open
timclausen opened this issue Feb 19, 2019 · 14 comments
Open

Barlow Condensed: Extra space after character ø #1851

timclausen opened this issue Feb 19, 2019 · 14 comments
Assignees
Labels
-- Upstream is working on it Designer is making changes in the upstream repo I Font Bug I Small Fix bugs fixed but nothing added
Milestone

Comments

@timclausen
Copy link

I'm having issues with Barlow Condensed when using it in Danish. Letter ø gets an additional spacing.

skaermbillede 2019-02-19 kl 14 05 42

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 19, 2019

Confirmed

screenshot 2019-02-19 at 13 11 54

I'll check the source now.

@Emetico
Copy link

Emetico commented Oct 8, 2019

This is still not fixed when the word starts with a big Ø
Udklip

@carnevalle
Copy link

@m4rc1e

Hi Marc. As @Emetico mentions this is still not fixed for uppercase scenarios with some of the font styles. Could this be reopend or should I create a new issue?

FireShot Capture 019 - Barlow Condensed - Google Fonts - fonts google com

@fitojb
Copy link
Contributor

fitojb commented Nov 15, 2021

@carnevalle The font’s source was updated, but the change still hasn’t reached the Google Fonts CDN. Please test with an updated build from https://github.com/jpt/barlow/tree/1.5/fonts as that version has a number of spacing and kerning improvements.

@RosaWagner
Copy link
Contributor

I reopened this issue since the font still has be be upgraded on GF

@RosaWagner RosaWagner reopened this Nov 25, 2021
@RosaWagner RosaWagner added I Font Bug I Small Fix bugs fixed but nothing added labels Nov 25, 2021
@RosaWagner RosaWagner assigned emmamarichal and unassigned m4rc1e Nov 25, 2021
@RosaWagner RosaWagner added this to the 2021 Q4 milestone Nov 25, 2021
@emmamarichal
Copy link
Collaborator

We are working on it (cc @RosaWagner), but the font file is quite complex (because of intermediate layers, filters, etc.), and it's difficult to build the font with fontmake.

@RosaWagner
Copy link
Contributor

The last update is still in a branch and there is not a release yet, I suggest we let @jpt work on it. Please @jpt ping us when the upgrade is ready :)

@RosaWagner RosaWagner added -- Upstream is working on it Designer is making changes in the upstream repo and removed - In Progress labels Dec 1, 2021
@jpt
Copy link
Contributor

jpt commented Dec 1, 2021

indeed, I am actively working on a large number of issues in barlow, including the ø - although I changed it years back at this point to not substitute the alternate shape at heavier weights because a number of norwegian readers complained initially and who was I to disagree 😅 but if that kind of design change is controversial given the google cdn's reach, happy to talk about it.

in case it's helpful for anyone following barlow's development more generally, I recently updated some milestones here - https://github.com/jpt/barlow/milestones
the dates are possibly overly optimistic but I needed to put some goalposts somewhere :)

@RosaWagner RosaWagner modified the milestones: 2021 Q4, 2022 Q1 Dec 17, 2021
@carnevalle
Copy link

@jpt @RosaWagner

Bad news. The Ø fix found in https://github.com/jpt/barlow/archive/refs/heads/1.5.zip has introduced a bug with percentage sign %. See attached screenshot.

barlow

@jpt
Copy link
Contributor

jpt commented Jan 4, 2022

Hi @carnevalle, the 1.5 branch is under active development and has more significant bugs than just the percentage sign right now; I wouldn't recommend using it until it's merged into the main branch. If you notice any other bugs, feel free to open an issue in the Barlow repo along with the others so I can track it.

@carnevalle
Copy link

@jpt

I'll do that. Do you want me to create an issue with this bug or is it already created somewhere?

@jpt
Copy link
Contributor

jpt commented Jan 5, 2022

oh, no, sorry I wasn;t more clear — I mean if you notice anything beyond the percentage sign. the percent is already fixed (though it's not yet in the font binaries it should be fixed in the Glyphs file)

@RosaWagner RosaWagner modified the milestones: 2022 Q1, 2022 Q2 Mar 11, 2022
@carnevalle
Copy link

@RosaWagner I can see these fixes are being moved from milestone to milestone. Is there any news about when a release would be expected?

@RosaWagner RosaWagner modified the milestones: 2022 Q2, 2022 Q3 Jul 1, 2022
@RosaWagner RosaWagner modified the milestones: 2022 Q3, 2022 Q4 Sep 15, 2022
@RosaWagner RosaWagner modified the milestones: 2022 Q4, 2023 Q1 Dec 8, 2022
@RosaWagner RosaWagner moved this from Todo to Blocked in Google Fonts Mar 9, 2023
@RosaWagner RosaWagner removed this from the 2023 Q1 milestone Mar 15, 2023
@RosaWagner RosaWagner added this to the Icebox milestone Jun 1, 2023
@jpt
Copy link
Contributor

jpt commented Apr 25, 2024

This should be fixed upstream in the 1.5 branch. I'm drafting a PR. Most of what I want to do before merging it (and opening a separate PR here) is to check some things in fontbakery and also double check some things related to the vertical metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Upstream is working on it Designer is making changes in the upstream repo I Font Bug I Small Fix bugs fixed but nothing added
Projects
Status: Blocked
Development

No branches or pull requests

8 participants