Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more specific path for method require #260

Closed
wants to merge 1 commit into from
Closed

use more specific path for method require #260

wants to merge 1 commit into from

Commits on Jul 25, 2016

  1. use more specific path for method require 

    We encounter a problem when we upgrade fs-extras from 0.18.3 to 0.30.0, all extra method like fs.move is undefined after we upgrade our service.

Our deploy system is a increment deploy system, so every history file was  on the machine.

In 0.18.3 the file path is `lib/move.js` and in 0.30.0 is `lib/move/index.js`, they can both by required by using `require('./move')`, so when we upgrade the fs-extras lib, the new `index.js` will require('lib/move.js') rather than `lib/move/index.js` since old file is still exist.

I think it won't hurt anything if we change require path to a more specific path, and will get a better compatibility.
    @hefangshi
    hefangshi authored Jul 25, 2016
    Configuration menu
    Copy the full SHA
    83c2439 View commit details
    Browse the repository at this point in the history