use more specific path for method require #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encounter a problem when we upgrade fs-extras from 0.18.3 to 0.30.0, all extra method like fs.move is undefined after we upgrade our service.
Our deploy system is a increment deploy system, so every history file was on the machine.
In 0.18.3 the file path is `lib/move.js` and in 0.30.0 is `lib/move/index.js`, they can both by required by using `require('./move')`, so when we upgrade the fs-extras lib, the new `index.js` will require('lib/move.js') rather than `lib/move/index.js` since old file is still exist.
I think it won't hurt anything if we change require path to a more specific path, and will get a better compatibility.
|
I don't see how this really changes anything? The |
|
Yes you are right, and the code is working great at in normal scenes. The thing is our deploy system is a increment deploy system, so there will be |
|
@hefangshi This is a problem with your deploy system, not fs-extra IMO. Going to close this for the time being. |
|
It has no harm for fs-extra, so why don't accept it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encounter a problem when we upgrade fs-extras from 0.18.3 to 0.30.0, all extra method like fs.move is undefined after we upgrade our service.
Our deploy system is a increment deploy system, so every history file was on the machine.
In 0.18.3 the file path is
lib/move.jsand in 0.30.0 islib/move/index.js, they can both by required by usingrequire('./move'), so when we upgrade the fs-extras lib, the newindex.jswill require('lib/move.js') rather thanlib/move/index.jssince old file is still exist.I think it won't hurt anything if we change require path to a more specific path, and will get a better compatibility.