Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite protection when generating keys and storing in a vault #570

Closed
chris-j-h opened this issue Dec 6, 2018 · 2 comments
Closed

Overwrite protection when generating keys and storing in a vault #570

chris-j-h opened this issue Dec 6, 2018 · 2 comments
Assignees
Labels

Comments

@chris-j-h
Copy link
Collaborator

The keys in a vault can be overwritten if new keys are generated with the same name

Tessera should check if keys already exist with the provided name and if so, provide a prompt to the user confirming if they want to overwrite these values.

@chris-j-h chris-j-h added the 0.8 label Dec 6, 2018
@chris-j-h chris-j-h self-assigned this Dec 6, 2018
@chris-j-h
Copy link
Collaborator Author

Additionally, Hashicorp key generation currently sets the key names as publicKey and privateKey. Providing the ability to set custom names would also help prevent keys from being overwritten.

@chris-j-h
Copy link
Collaborator Author

This issue has been closed as an alternative resolution was used. With #565 and #574, Tessera can retrieve the previous versions of a secret stored in an Azure or Hashicorp vault, thereby preventing a complete overwrite of the values stored in the vault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants