Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Hashicorp Vault to store Tessera keys #565

Merged
merged 61 commits into from Dec 17, 2018
Merged

Add support for Hashicorp Vault to store Tessera keys #565

merged 61 commits into from Dec 17, 2018

Conversation

chris-j-h
Copy link
Collaborator

@chris-j-h chris-j-h commented Dec 5, 2018

Add Hashicorp Vault to supported key vaults that can be used with Tessera. Features include:

  • Store generated public/private key pairs in a Vault configured with a version 2 k/v secret engine
  • Retrieve public/private key pairs and previous versions of key pair from a pre-configured Vault
  • TLS communication between Tessera and the Vault server is supported. Non-TLS communication is also allowed for development/test purposes
  • Vault config can be provided in configfile, and the corresponding CLI options have been added to provide this information for key generation
  • GetSecretData and SetSecretData added as arguments for the KeyVaultService methods. This allows for the same method signatures to be used in the Hashicorp and Azure implementations despite each provider's different interpretation of what constitutes a secret

Switch to use vault-java-driver instead of spring-vault-core
Add config item for TLS certificate path
prd-fox
prd-fox previously approved these changes Dec 6, 2018
melowe
melowe previously approved these changes Dec 6, 2018
@namtruong namtruong dismissed stale reviews from melowe and prd-fox via 97690f6 December 7, 2018 11:41
namtruong
namtruong previously approved these changes Dec 7, 2018
@chris-j-h
Copy link
Collaborator Author

Changes have been made to support v2 of the k/v secrets engine (i.e. versioning of secrets and retrieval of previous versions of a secret)

@Krish1979 Krish1979 merged commit 08fa1bb into Consensys:master Dec 17, 2018
@Krish1979 Krish1979 deleted the feature/hashicorp-vault-support branch December 17, 2018 18:53
@prd-fox prd-fox added 0.8 and removed review labels Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants