Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retrieval of previous versions of Azure secrets #574

Merged
merged 6 commits into from Dec 19, 2018
Merged

Enable retrieval of previous versions of Azure secrets #574

merged 6 commits into from Dec 19, 2018

Conversation

chris-j-h
Copy link
Collaborator

As an alternative to the solution outlined in Issue 570, this will improve Azure support by allowing Tessera to retrieve previous versions of secrets. If no version is provided in the Tessera configfile then the latest version is retrieved by default.

This means that even if secrets are updated the previous values are not lost and Tessera can continue to use the older keys.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #574 into master will decrease coverage by 0.01%.
The diff coverage is 97.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #574      +/-   ##
============================================
- Coverage     99.45%   99.43%   -0.02%     
- Complexity     1627     1643      +16     
============================================
  Files           255      256       +1     
  Lines          4953     4991      +38     
  Branches        246      247       +1     
============================================
+ Hits           4926     4963      +37     
- Misses            4        5       +1     
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
...a/key/vault/azure/AzureKeyVaultClientDelegate.java 50% <0%> (-10%) 1 <0> (ø)
...tessera/key/generation/AzureVaultKeyGenerator.java 100% <100%> (ø) 6 <0> (ø) ⬇️
.../tessera/config/vault/data/AzureGetSecretData.java 100% <100%> (ø) 4 <2> (+1) ⬆️
...rum/tessera/config/keypairs/AzureVaultKeyPair.java 100% <100%> (ø) 9 <3> (+2) ⬆️
.../tessera/key/vault/azure/AzureKeyVaultService.java 100% <100%> (ø) 7 <0> (ø) ⬇️
...um/tessera/config/keypairs/UnsupportedKeyPair.java 100% <100%> (ø) 32 <5> (+4) ⬆️
...c/main/java/com/quorum/tessera/config/KeyData.java 100% <100%> (ø) 30 <5> (+4) ⬆️
...config/constraints/AzureVaultKeyPairValidator.java 100% <100%> (ø) 5 <5> (?)
...quorum/tessera/config/adapters/KeyDataAdapter.java 97.33% <100%> (+0.23%) 18 <0> (ø) ⬇️
...rum/tessera/keypairconverter/KeyPairConverter.java 100% <100%> (ø) 5 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fa1bb...5fac387. Read the comment docs.

@Krish1979 Krish1979 merged commit 0872f4f into Consensys:master Dec 19, 2018
@prd-fox prd-fox added the 0.8 label Jan 2, 2019
@chris-j-h chris-j-h deleted the feature/azure-vault-versioning branch January 4, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants