Skip to content

Allow workspaces outside the packages/ directory#2169

Merged
cristiano-belloni merged 2 commits intomainfrom
feature/relax-verify-workspace
Sep 28, 2022
Merged

Allow workspaces outside the packages/ directory#2169
cristiano-belloni merged 2 commits intomainfrom
feature/relax-verify-workspace

Conversation

@cristiano-belloni
Copy link
Contributor

The verifyWorkspaceDependencies check should not reject modular packages found outside of the packages directory.

Consider the file system:

- package.json
- apps
  |- some-app-not-in-packages
- packages
  |- package-a
  |- package-b (not a modular package)

When the modular check runs as part of pre-flight, the some-app-not-in-packages package will cause the check to fail because it is outside the packages directory.

Given that it was found by the workspace-resolver, the check should not fail.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: 2bf087c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Sep 27, 2022

Coverage Status

Coverage decreased (-0.4%) to 33.217% when pulling 2bf087c on feature/relax-verify-workspace into 14b1334 on main.

@cristiano-belloni cristiano-belloni merged commit 32f4a4d into main Sep 28, 2022
@cristiano-belloni cristiano-belloni deleted the feature/relax-verify-workspace branch September 28, 2022 11:55
@github-actions github-actions bot mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants