Allow workspaces outside the packages/ directory#2169
Merged
cristiano-belloni merged 2 commits intomainfrom Sep 28, 2022
Merged
Allow workspaces outside the packages/ directory#2169cristiano-belloni merged 2 commits intomainfrom
cristiano-belloni merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 2bf087c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
sgb-io
reviewed
Sep 28, 2022
sgb-io
reviewed
Sep 28, 2022
sgb-io
reviewed
Sep 28, 2022
packages/modular-scripts/src/__tests__/check/verifyWorkspaceDependencies.test.ts
Show resolved
Hide resolved
sgb-io
approved these changes
Sep 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verifyWorkspaceDependencies check should not reject modular packages found outside of the packages directory.
Consider the file system:
When the modular check runs as part of pre-flight, the some-app-not-in-packages package will cause the check to fail because it is outside the packages directory.
Given that it was found by the workspace-resolver, the check should not fail.