Skip to content

Feature/refactor modular config#2159

Merged
cristiano-belloni merged 19 commits intomainfrom
feature/refactor-modular-config
Sep 26, 2022
Merged

Feature/refactor modular config#2159
cristiano-belloni merged 19 commits intomainfrom
feature/refactor-modular-config

Conversation

@cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented Sep 21, 2022

Factor out Webpack configuration in separate files (parts) and use webpack-merge to merge them.

Configuration is now divided into:

  1. Style loaders (order is essential here, so style loaders are essentially an atomic block)
  2. Type app specific configuration (normal conf + plugin conf)
  3. Type esm-view specific configuration (normal conf + plugin conf) + esm rewriting utilities
  4. Development build (modular start) specific configuration (normal conf + plugin conf)
  5. Production build (modular start) specific configuration (normal conf + plugin conf)
  6. Base (common) configuration, separated into plugin conf and regular configuration
  7. webpack.config file, which essentially parses the environment and collates the right parts with webpack-merge

  • factor out style loaders
  • factor out app conf
  • factor out esm-view conf
  • factor out production conf
  • factor out development conf
  • factor out base conf
  • merge configurations

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

🦋 Changeset detected

Latest commit: 906b441

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Sep 21, 2022

Coverage Status

Coverage decreased (-0.03%) to 33.358% when pulling 906b441 on feature/refactor-modular-config into 902e03a on main.

@cristiano-belloni cristiano-belloni marked this pull request as ready for review September 26, 2022 09:52
"modular-scripts": patch
---

Refactor modular config to use webpack-metge and be more readable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo on "merge"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@cristiano-belloni cristiano-belloni merged commit 70470c0 into main Sep 26, 2022
@cristiano-belloni cristiano-belloni deleted the feature/refactor-modular-config branch September 26, 2022 15:29
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants