Feature/refactor modular config#2159
Merged
cristiano-belloni merged 19 commits intomainfrom Sep 26, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 906b441 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
ayseenver
reviewed
Sep 26, 2022
.changeset/metal-pigs-jog.md
Outdated
| "modular-scripts": patch | ||
| --- | ||
|
|
||
| Refactor modular config to use webpack-metge and be more readable |
Contributor
There was a problem hiding this comment.
There's a typo on "merge"
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks!
added 2 commits
September 26, 2022 10:58
ayseenver
approved these changes
Sep 26, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out Webpack configuration in separate files (parts) and use webpack-merge to merge them.
Configuration is now divided into:
appspecific configuration (normal conf + plugin conf)esm-viewspecific configuration (normal conf + plugin conf) + esm rewriting utilitiesmodular start) specific configuration (normal conf + plugin conf)modular start) specific configuration (normal conf + plugin conf)