support node 16 explicitly and run test workflow against target node by LukeSheard · Pull Request #1546 · jpmorganchase/modular

LukeSheard · 2022-04-06T12:49:08Z

Updating the setup-node configuration so that the versions of node that we support are explictly coded in, this is because currently we're running a workflow with the latest node v.x version in a range, not the minimum version we support which leads to runtime differences.

cc. @steveukx / @cristiano-belloni

* Bump rollup from 2.67.2 to 2.70.1 Bumps [rollup](https://github.com/rollup/rollup) from 2.67.2 to 2.70.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.67.2...v2.70.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update snapshots Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com>

* Bump commander from 8.2.0 to 9.1.0 Bumps [commander](https://github.com/tj/commander.js) from 8.2.0 to 9.1.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](tj/commander.js@v8.2.0...v9.1.0) --- updated-dependencies: - dependency-name: commander dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Create silent-donkeys-peel.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com>

Bumps [@changesets/cli](https://github.com/changesets/changesets) from 2.21.1 to 2.22.0. - [Release notes](https://github.com/changesets/changesets/releases) - [Changelog](https://github.com/changesets/changesets/blob/main/docs/modifying-changelog-format.md) - [Commits](https://github.com/changesets/changesets/compare/@changesets/cli@2.21.1...@changesets/cli@2.22.0) --- updated-dependencies: - dependency-name: "@changesets/cli" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.25.3 to 2.26.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.25.3...v2.26.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 4.7.4 to 4.8.0. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v4.7.4...v4.8.0) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@changesets/changelog-github](https://github.com/changesets/changesets) from 0.4.3 to 0.4.4. - [Release notes](https://github.com/changesets/changesets/releases) - [Changelog](https://github.com/changesets/changesets/blob/main/docs/modifying-changelog-format.md) - [Commits](https://github.com/changesets/changesets/compare/@changesets/changelog-github@0.4.3...@changesets/changelog-github@0.4.4) --- updated-dependencies: - dependency-name: "@changesets/changelog-github" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 21.0.2 to 21.0.3. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v21.0.3/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.42 to 17.0.43. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [dotenv-expand](https://github.com/motdotla/dotenv-expand) from 8.0.2 to 8.0.3. - [Release notes](https://github.com/motdotla/dotenv-expand/releases) - [Changelog](https://github.com/motdotla/dotenv-expand/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv-expand@v8.0.2...v8.0.3) --- updated-dependencies: - dependency-name: dotenv-expand dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.0.0...v3.1.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: micromatch dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…versions

changeset-bot · 2022-04-06T12:49:10Z

🦋 Changeset detected

Latest commit: 8901b9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
create-modular-react-app	Patch
modular-scripts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2022-04-06T13:04:28Z

Coverage remained the same at 28.786% when pulling 8901b9f on bugfix/workflow-node-version into f15e790 on main.

cristiano-belloni · 2022-04-06T16:58:03Z

packages/modular-scripts/package.json

  },
  "engines": {
-    "node": "^12.13.0 || ^14.15.0 || >=15.0.0"
+    "node": "^12.20.0 || ^14.15.0 || >=15.0.0 || >=16.0.0"


Since we're updating the engines, wouldn't it be better to merge this in #1538 and have teams testing it in alpha for a while? I bet that some teams run node < 12.20, for example.

If you look at the original commit workflows here, installation fails for <12.20.0 unless --ignore-engines is already set because of the current find-up dependency. This was actually one of the reasons that I'm proposing this change to ensure that dependency upgrades also don't cause failures in the version of node we support.

In theory this release should be a no-op in a practical sense.

dependabot bot and others added 13 commits March 29, 2022 14:39

Fix failing tests (#1543)

6bbc904

support node 16 explicitly and run test workflow against target node …

9f48679

…versions

LukeSheard and others added 2 commits April 6, 2022 14:40

fix node versions so that tests run

8115519

Create dirty-mugs-double.md

8b3f1f5

LukeSheard requested review from benpryke and cristiano-belloni April 6, 2022 16:53

cristiano-belloni reviewed Apr 6, 2022

View reviewed changes

fix node versions so that tests run and remove 15 since it's unsupported

8901b9f

cristiano-belloni changed the base branch from main to feature/node-12-remove-support April 7, 2022 10:42

cristiano-belloni merged commit 0a0bc65 into feature/node-12-remove-support Apr 7, 2022

cristiano-belloni deleted the bugfix/workflow-node-version branch April 7, 2022 10:58

github-actions bot mentioned this pull request Apr 7, 2022

Version Packages (alpha-webpack5) #1554

Merged

LukeSheard restored the bugfix/workflow-node-version branch April 7, 2022 13:22

LukeSheard deleted the bugfix/workflow-node-version branch April 12, 2022 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support node 16 explicitly and run test workflow against target node#1546

support node 16 explicitly and run test workflow against target node#1546
cristiano-belloni merged 16 commits intofeature/node-12-remove-supportfrom
bugfix/workflow-node-version

LukeSheard commented Apr 6, 2022 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 6, 2022 •

edited

Loading

Uh oh!

coveralls commented Apr 6, 2022 •

edited

Loading

Uh oh!

cristiano-belloni Apr 6, 2022

Uh oh!

LukeSheard Apr 6, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

LukeSheard commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coveralls commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristiano-belloni Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

LukeSheard Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LukeSheard commented Apr 6, 2022 •

edited

Loading

changeset-bot bot commented Apr 6, 2022 •

edited

Loading

coveralls commented Apr 6, 2022 •

edited

Loading

LukeSheard Apr 6, 2022 •

edited

Loading