Implement ModuleScopePluign for esbuild builds.#1094
Merged
LukeSheard merged 2 commits intomainfrom Nov 24, 2021
Merged
Conversation
🦋 Changeset detectedLatest commit: 2da62df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
cangarugula
reviewed
Nov 24, 2021
packages/modular-scripts/src/__tests__/esbuild-scripts/moduleScopePlugin.test.ts
Show resolved
Hide resolved
packages/modular-scripts/src/__tests__/esbuild-scripts/__fixtures__/module-scope/src/index.tsx
Show resolved
Hide resolved
| svgrPlugin(), | ||
| incrementalReporterPlugin(), | ||
| ]; | ||
| const plugins: esbuild.Plugin[] = [incrementalReporterPlugin()]; |
Contributor
There was a problem hiding this comment.
why are we removing the svgrPlugin here?
Contributor
Author
There was a problem hiding this comment.
Common plugins are setup in createEsbuildConfig.ts now so that we can minimalize differences.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the equivalent of the ModuleScopePlugin which exists for webpack builds but for esbuild code paths. Resolves any relative imports from their current location to ensure that code is contained within the
srcdirectory.See
packages/modular-scripts/react-dev-utils/ModuleScopePlugin.jsfor the original implementation