Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java token order in special cases (new) #854

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix Java token order in special cases (new) #854

merged 1 commit into from
Jan 17, 2023

Conversation

brodmo
Copy link
Contributor

@brodmo brodmo commented Dec 19, 2022

Adresses issue #852. Tests seem to be unaffected. Is dependent on pull request #830 to minimize conflicts

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change bug Issue/PR that involves a bug and removed enhancement Issue/PR that involves features, improvements and other changes labels Dec 19, 2022
@tsaglam
Copy link
Member

tsaglam commented Jan 17, 2023

@mbrdl I merged #830. Could you update the PR to clean up the history?

@tsaglam tsaglam self-requested a review January 17, 2023 07:47
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.9% 91.9% Coverage
0.0% 0.0% Duplication

@brodmo
Copy link
Contributor Author

brodmo commented Jan 17, 2023

done

tsaglam
tsaglam approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tsaglam tsaglam merged commit 208e503 into jplag:develop Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brodmo @tsaglam