Generate Java assign token more often #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodmo
force-pushed
the
java-assign
branch
4 times, most recently
from
37e4846
to
cc3a3b4
Compare
tsaglam
added
enhancement
|
You need to adapt some expected values of test cases for this PR to pass the build. However, do not adapt the E2E tests yet. |
|
Kudos, SonarCloud Quality Gate passed! |
tsaglam
requested changes
Dec 13, 2022
tsaglam
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java,
i++is syntactic sugar fori += 1, which in turn is syntactic sugar fori = i + 1. Currently, aJ_ASSIGNtoken is only generated in the last case, no tokens are generated in the other two cases. This inconsistency can be resolved by also generating aJ_ASSIGNtoken for compound assignments and increment/decrement operations.