Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly named ECDSA algorithm #219

Merged
merged 4 commits into from
Oct 24, 2016
Merged

Conversation

mike9005
Copy link
Contributor

Per the RFC on ECDSA in TLS, the signing algorithm using the P-521 elliptic curve and SHA-512 is called ES521, instead of ES512.

@coveralls
Copy link

coveralls commented Sep 22, 2016

Coverage Status

Coverage decreased (-21.4%) to 78.598% when pulling ebd2fb9 on mike9005:es521_fix into 3edaa53 on jpadilla:master.

@coveralls
Copy link

coveralls commented Sep 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 89f9a9d on mike9005:es521_fix into 3edaa53 on jpadilla:master.

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with something like this, although we need to do so without breaking compat. We'd need to make sure everything still works for users using ES512 as an algo.

@mark-adams
Copy link
Contributor

I agree with @jpadilla. At least until the next major version, this should still allow ES512 and emit a warning if you use it.

@mark-adams mark-adams merged commit 18160c4 into jpadilla:master Oct 24, 2016
@jpadilla jpadilla added this to the v1.4.3 milestone Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants