-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algorithm ES512 really was named correctly prior to issue #219 #465
Labels
stale
Issues without activity for more than 60 days
Comments
@douganger great catch. https://tools.ietf.org/html/rfc7518#section-3.1
|
jpadilla
added a commit
that referenced
this issue
Jan 6, 2020
jpadilla
added a commit
that referenced
this issue
Apr 6, 2020
Addressing this for v2 #470 |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue #219 requested that the algorithm ES512 be renamed to ES521, citing RFC4492. The reporter correctly noted that the curve is named P-521, not P-512.
However, RFC4492 addresses the names of standard curves, not algorithm specifications for JSON Web Signatures or JSON Web Tokens.
In RFC7518, the table under section 3.1 on page 6 specifies ES512 as the "alg" Param Value for ECDSA using P-521 and SHA-512.
Currently, both options are accepted, but there is a comment in algorithms.py that ES512 is only left for backward compatibility after a fix. ES512 is in fact the correct value.
The text was updated successfully, but these errors were encountered: