Fix HMR support #20
Merged
Fix HMR support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2bd6bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Any update or is there any way we can help with this effort to fix HMR? |
joshwooding
force-pushed
the
try-tackle-hmr-issues
branch
4 times, most recently
from
302b490
to
6211a06
Compare
joshwooding
commented
Oct 5, 2023
| @@ -81,5 +101,8 @@ export default function reactDocgenTypescript(config: Options = {}): Plugin { | |||
| return src; | |||
| } | |||
| }, | |||
| async handleHotUpdate() { | |||
joshwooding
force-pushed
the
try-tackle-hmr-issues
branch
2 times, most recently
from
3d9ab6d
to
2c03f87
Compare
joshwooding
force-pushed
the
try-tackle-hmr-issues
branch
from
2c03f87
to
e2bd6bc
Compare
|
/release-pr |
|
🫰✨ Thanks @joshwooding! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @joshwooding/vite-plugin-react-docgen-typescript@0.0.0-snapshot-20231005222330 |
| }; | ||
|
|
||
| return result; | ||
| return ts.createProgram(files, compilerOptions, undefined, oldProgram); |
There was a problem hiding this comment.
Hey @joshwooding
What happens if we pass the oldProgram to the ts.createProgram function? Is Typescript able to speed up the new program's creation?
There was a problem hiding this comment.
Yeah, that's in theory how it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21