Closed
Conversation
This reverts commit d5e291c.
Owner
Contributor
Author
|
GitHub will take care of it all. A revert commit just removes a previously merged PR and commits it to git history. If you approve and merge, you're all set. |
Owner
|
ok then I think I'll merge this one and then we can disregard #25 since it's mostly redundant with this one |
Contributor
Author
|
Alright, sounds good
…On Wed, Oct 12, 2022 at 7:43 AM joshuasorkin ***@***.***> wrote:
ok then I think I'll merge this one and then we can disregard #25
<#25> since it's
mostly redundant with this one
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGFGIU4FCNMFDYWMOGFA5TWCZFZJANCNFSM6AAAAAARCAG5LU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
....oh wait i'm confused. if I confirm merge on this one, am i confirming the revert, or am I committing #16? |
Contributor
Author
|
If you confirm merge on this one, you're confirming the revert which is essentially rolling back from merging #16. |
Owner
Contributor
Author
|
Yeah, exactly. Cool. That's fine, I can live with untagged PRs.
…On Wed, Oct 12, 2022 at 7:58 AM joshuasorkin ***@***.***> wrote:
ok so if I do nothing with this one, the changes from #16
<#16> will stay?
That's what I want, assuming you're ok with #16
<#16> not being a
tagged PR.
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGFGIXGVCR4SCZUT7MBKIDWCZHRTANCNFSM6AAAAAARCAG5LU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #16