Skip to content

Sequelize package json fix#16

Merged
minademian merged 23 commits intoproductionfrom
sequelize-package-json-fix
Oct 10, 2022
Merged

Sequelize package json fix#16
minademian merged 23 commits intoproductionfrom
sequelize-package-json-fix

Conversation

@joshuasorkin
Copy link
Copy Markdown
Owner

@joshuasorkin joshuasorkin commented Sep 30, 2022

This includes the package.json changes I made to implement the Sequelize fix described here. I also made some other changes to suppress some errors so that I could test the Sequelize operations:

  • commented out the Session related code in AppInitializer
  • changed all the sequelize.query to this.sequelize.query
  • added defaults for the insertEvent replacements
  • made insertEvent into an async/await function
  • removed the sequelize and sequelize_ssl from the top of the class (the ones that aren't this.sequelize etc)

@joshuasorkin
update pg and sequelize versions in package.json
249105e
@joshuasorkin
comment out session-related code in appInitializer
3b500c8
@joshuasorkin
remove the sequelize and sequelize_ssl from database.js, the ones tha…
d40c76f 
…t weren't scoped as this.sequelize etc
@joshuasorkin
change sequelize.query to this.sequelize.query
621453e
@joshuasorkin
add default null strings for reqBody items
e76824c
@joshuasorkin
make insertEvent async/await
6c5c15b
@joshuasorkin
add try catch to insertEvent
74171c9
@joshuasorkin
use console.log
1a71680
@joshuasorkin
add todo comment for 'event' relation
2d6883f
@joshuasorkin
define database in worker using this.database
1e23dc4
@joshuasorkin
in worker, replace all 'database' with 'this.database'
dc8c301
@joshuasorkin
fix command calling in sms
0b5a08e
@joshuasorkin
in availableNotifier, move singleton assignment into constructor and …
6b23216 
…set all database references to this.database
@joshuasorkin
add default function
96620fb
@joshuasorkin
include default in key binding
7fa1446
@joshuasorkin
use let to declare vars
ffff75d
@joshuasorkin
fix manualResponse
52c9796
@joshuasorkin
create new instance of Password()
994a38a
@joshuasorkin
change database to this.database in password.js
6749b10
@joshuasorkin
bypass admin password check until I can populate the db correctly
025fa64
@joshuasorkin
database change
3d678c5
@joshuasorkin
comment out callerWorkerSid attribute, per Twilio API this attribute …
d8d95f0 
…is no longer supported by enqueue()
@joshuasorkin
additional console logging
8c6f80a
minademian
minademian approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@minademian minademian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good step in the direction of getting us towards a v1

Comment thread src/appInitializer.js
@minademian minademian merged commit d5e291c into production Oct 10, 2022
minademian added a commit that referenced this pull request Oct 11, 2022
@minademian
Revert "Sequelize package json fix (#16)"
cb1a478 
This reverts commit d5e291c.
@minademian minademian mentioned this pull request Oct 11, 2022
Closed
@joshuasorkin joshuasorkin mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@minademian minademian minademian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshuasorkin @minademian