Skip to content

Commit

Permalink
Remove cleanup on side threads (apache#19378)
Browse files Browse the repository at this point in the history
* Remove cleanup on side threads

* removed comment
  • Loading branch information
ptrendx authored and josephevans committed Feb 25, 2022
1 parent 9e9e98c commit 7c34851
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions src/engine/naive_engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,11 @@ class NaiveEngine final : public Engine {
LOG(INFO) << "Engine shutdown";
for (size_t i = 0; i < streams_.size(); ++i) {
if (streams_[i] != nullptr) {
// Catch exception for CUDA driver shutdown
MSHADOW_CATCH_ERROR(mshadow::DeleteStream(streams_[i]));
streams_[i] = nullptr;
}
}
for (size_t i = 0; i < aux_streams_.size(); ++i) {
if (aux_streams_[i] != nullptr) {
delete aux_streams_[i];
aux_streams_[i] = nullptr;
}
}
Expand Down
4 changes: 0 additions & 4 deletions src/engine/threaded_engine_perdevice.cc
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,6 @@ class ThreadedEnginePerDevice : public ThreadedEngine {
while (task_queue->Pop(&opr_block)) {
this->ExecuteOprBlock(run_ctx, opr_block);
}
// Catch exception for CUDA driver shutdown
MSHADOW_CATCH_ERROR(mshadow::DeleteStream<gpu>(stream));
if (aux_stream != nullptr)
delete aux_stream;
#else
ready_event->signal();
#endif
Expand Down

0 comments on commit 7c34851

Please sign in to comment.