Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove cleanup on side threads #19378

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Remove cleanup on side threads #19378

merged 2 commits into from
Oct 21, 2020

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Oct 19, 2020

Description

Fixes #19360

@szha @mseth10

@mxnet-bot
Copy link

Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, windows-gpu, unix-cpu, clang, centos-cpu, website, unix-gpu, sanity, windows-cpu, miscellaneous, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 19, 2020
@ptrendx ptrendx mentioned this pull request Oct 19, 2020
Open
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 19, 2020
@ptrendx
Copy link
Member Author

ptrendx commented Oct 20, 2020

@mxnet-bot run ci [centos-cpu, centos-gpu, miscellaneous, unix-cpu, unix-gpu, windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous, windows-cpu, centos-gpu, unix-gpu, centos-cpu, unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
mseth10
mseth10 reviewed Oct 20, 2020
View reviewed changes
src/engine/naive_engine.cc Outdated Show resolved Hide resolved
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
mseth10
mseth10 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha szha merged commit 43750c8 into apache:master Oct 21, 2020
@barry-jin barry-jin mentioned this pull request Oct 27, 2020
Open
barry-jin added a commit to barry-jin/incubator-mxnet that referenced this pull request Oct 27, 2020
@barry-jin
Revert "Remove cleanup on side threads (apache#19378)"
e0ee6c2 
This reverts commit 43750c8.
@barry-jin barry-jin mentioned this pull request Oct 27, 2020
Closed
6 tasks
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Nov 17, 2020
@ptrendx @chinakook
Remove cleanup on side threads (apache#19378)
fa859c0 
* Remove cleanup on side threads

* removed comment
This was referenced Nov 18, 2020
Open
Merged
@chinakook
Copy link
Contributor

I'm sure that the train_faster_rcnn.py in gluon-cv will get weird error after this patch.

terminate called recursively
  what():  [10:03:36] /home/xxxxx/mx/3rdparty/mshadow/mshadow/./stream_gpu-inl.h:192: Check failed: err == CUDNN_STATUS_SUCCESS (1 vs. 0) : CUDNN_STATUS_NOT_INITIALIZED```

chinakook pushed a commit to chinakook/mxnet that referenced this pull request Nov 23, 2020
@ptrendx @chinakook
Remove cleanup on side threads (apache#19378)
2f3e2c6 
* Remove cleanup on side threads

* removed comment
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Feb 24, 2022
@ptrendx @josephevans
Remove cleanup on side threads (apache#19378)
9a4d568 
* Remove cleanup on side threads

* removed comment
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Feb 25, 2022
@ptrendx @josephevans
Remove cleanup on side threads (apache#19378)
7c34851 
* Remove cleanup on side threads

* removed comment
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Feb 25, 2022
@ptrendx @josephevans
Remove cleanup on side threads (apache#19378)
50df21b 
* Remove cleanup on side threads

* removed comment
This was referenced Feb 25, 2022
Merged
Merged
josephevans added a commit that referenced this pull request Feb 28, 2022
@josephevans @ptrendx
Remove cleanup on side threads (#19378) (#20916)
438b2af 
* Remove cleanup on side threads

* removed comment

Co-authored-by: Przemyslaw Tredak <[email protected]>
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Feb 28, 2022
@ptrendx @josephevans
Remove cleanup on side threads (apache#19378)
1f878c4 
* Remove cleanup on side threads

* removed comment
josephevans added a commit that referenced this pull request Mar 1, 2022
@josephevans @ptrendx
Remove cleanup on side threads (#19378) (#20917)
8041c0d 
* Remove cleanup on side threads

* removed comment

Co-authored-by: Przemyslaw Tredak <[email protected]>
@ann-qin-lu ann-qin-lu mentioned this pull request Mar 19, 2022
Open
@DickJC123 DickJC123 mentioned this pull request Feb 17, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mseth10 mseth10 mseth10 approved these changes

@DickJC123 DickJC123 Awaiting requested review from DickJC123

@szha szha Awaiting requested review from szha

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SegFault while testing MXNet binaries for CUDA-11.0 using pytest
6 participants
@ptrendx @mxnet-bot @chinakook @mseth10 @szha @lanking520