Simplify the strings for modal titles (preview) #7864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
added a commit
that referenced
this pull request
Sep 11, 2015
Simplify the strings for modal titles (preview)
wilsonge
added a commit
to wilsonge/joomla-cms
that referenced
this pull request
Sep 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple string change for #7819
Thanks @brianteeman
@wilsonge George please update #7810 to use
'title' => JText::_('COM_MEDIA_PREVIEW'),What was changed:
we had Image preview and Video Preview and replace those for just Preview.
Mind that we can do those changes (deleting a string) since those strings are only available to the staging version (introduced only few days ago)