-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Use bootstrap modal for preview on com_media #7819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bootstrap modal for preview on com_media #7819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilsonge George this muted part together with the other lines above should be enough for the modal to open in the parent window. Still haven’t found a way to update the video source, need to walk through the API/code of the player
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just do something like
jQuery(document).ready(function($){
window.parent.document.updateUploader();
$('.img-preview, .preview').each(function(index, value) {
$(this).on('click', function(e) {
window.parent.jQuery('#videoPreview.modal video.mejs-player')[0].player.setSrc($(this).attr('href'));
window.parent.jQuery('#imagePreview').modal('show');
return false;
});
});
});|
Looks OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this string needs to go as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it’s needed for #7819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Tested successfully This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7819. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7819. |
Scope
Eliminate mootools usage and use bootstrap modal for previewing the images.
Also scripts and stylesheets were called all over the place, now they follow Joomla's best practices
B/C
As long as the templates use bootstrap (admin area) there shouldn’t be any problems. Any overrides NEED to be updated!
Performance
Should be a bit quicker without mootools eating some of the rendering time, downloading, http requests etc.
Testing
Apply the patch and see if everything still works correctly.
Report any problems or any ideas for improvement
Preview