Skip to content

Conversation

@Erftralle
Copy link
Contributor

Test instructions

  • Go to Menu Manager: New Menu Item
  • Enter a menu title
  • Select Single Contact for Menu Item Type
  • Do not select any contact
  • Click on Save or Save & Close

You will recognize:

  • The system message container just displays the message Error without any hint to the field concerned
  • The field label will not be coloured red
  • If you select a contact now the red colouring is not removed

After applaying the patch:

  • The system message container now displays the additional message Invalid field: Select Contact
  • The field label will be coloured red
  • After selecting a contact the red colouring is removed now

System information

Latest Joomla! staging

@MATsxm
Copy link

MATsxm commented May 4, 2015

@test
able to reproduce
then #6888 works as described.
thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6888.

@dgrammatiko
Copy link
Contributor

@test success

screen shot 2015-05-05 at 1 14 53

@peterlose
Copy link
Contributor

All good!

@zero-24
Copy link
Contributor

zero-24 commented May 5, 2015

Thanks for testing and coding moving to RTC now 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6888.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 5, 2015
wilsonge added a commit that referenced this pull request May 5, 2015
…ingle-contact

[imp]Client side validation for menu type single contact
@wilsonge wilsonge merged commit 07eb02b into joomla:staging May 5, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone May 5, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@Erftralle Erftralle deleted the client-validation-menu-type-single-contact branch August 15, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants