Skip to content

Conversation

@Erftralle
Copy link
Contributor

Test instructions

  • Go to Menu Manager: New Menu Item
  • Enter a menu title
  • Select Single article for Menu Item Type
  • Do not select any article
  • Click on Save or Save & Close

You will recognize:

  • The system message container just displays the message Error without any hint to the field concerned
  • The field label will not be coloured red
  • If you select an article now the red colouring is not removed

After applaying the patch:

  • The system message container now displays the additional message Invalid field: Select Article
  • The field label will be coloured red
  • After selecting an article the red colouring is removed now

System information

Latest Joomla! staging

If this amendment is agreed I would provide similar changes for the menu types Single contact and Single newsfeed. See also #6654 and #6761 dealing with the same problem.

@dgrammatiko
Copy link
Contributor

@test success

The rendered msg:
screen shot 2015-05-03 at 2 55 22

This is B/C and I think it should be also applied to contact and newsfeed! Thanks @Erftralle

@zero-24
Copy link
Contributor

zero-24 commented May 3, 2015

Thanks @Erftralle works great here! Moving RTC 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6885.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 3, 2015
@Erftralle
Copy link
Contributor Author

Thanks a lot for testing.

I have created pull requests #6888 and #6889 which apply the same changes to the client side validation of the menu item types Single Contact and Single News Feed.

wilsonge added a commit that referenced this pull request May 4, 2015
…ingle-article

[imp]Client side validation for menu type single article
@wilsonge wilsonge merged commit bd2a7bb into joomla:staging May 4, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone May 4, 2015
@wilsonge
Copy link
Contributor

wilsonge commented May 4, 2015

Merged - thanks so much!

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@Erftralle Erftralle deleted the client-validation-menu-type-single-article branch August 15, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants