CLEANING-JAdapter #6679
Merged
CLEANING-JAdapter #6679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some nested conditionals and moved the getAdapter method above the setAdapter method because getAdapter uses setAdapter.
|
Any chance of this getting merged? |
|
Thank you @Mathewlenning! |
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
May 8, 2016
…leanup-installer-plugins * 'staging' of https://github.com/joomla/joomla-cms: Smart Search: utf8_strpos: Offset must be an integer (joomla#10303) Removed an redundant else clause from JFeedParser::processElement (joomla#7961) CLEANING-JDataSet (joomla#7947) CLEANING-JAdapter (joomla#6679) Same treatment as JArchiveBzip2 and JArchiveGzip (joomla#6515) Cleaning up JArchiveBzip2 (joomla#6495) Removed the nested conditional switch construct (joomla#6338) add edit tooltip to modules (joomla#10295) New installer plugins: remove the dot in the plugin name and other language review (joomla#10299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some nested conditionals and moved the getAdapter method above the setAdapter method because getAdapter uses setAdapter.