Skip to content

Conversation

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented May 7, 2016

Summary of Changes

Very simple PR just to add the "Edit" tooltip that is missing in com_modules.

After PR
image

Testing Instructions

Code review, or:

  1. Apply patch
  2. Go to Extensions -> Modules and check the toolip on overring the modules title.

@MATsxm
Copy link

MATsxm commented May 7, 2016

I have tested this item ✅ successfully on 9108a7b

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10295.

@BurtNL
Copy link

BurtNL commented May 8, 2016

I have tested this item ✅ successfully on 9108a7b

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10295.

@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

RTC based on the tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10295.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 8, 2016
@wilsonge wilsonge merged commit 0a5e19b into joomla:staging May 8, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 8, 2016
@andrepereiradasilva
Copy link
Contributor Author

thanks for testing, comments and merging!

@andrepereiradasilva andrepereiradasilva deleted the patch-8 branch May 8, 2016 09:55
roland-d added a commit to roland-d/joomla-cms that referenced this pull request May 8, 2016
…leanup-installer-plugins

* 'staging' of https://github.com/joomla/joomla-cms:
  Smart Search: utf8_strpos: Offset must be an integer (joomla#10303)
  Removed an redundant else clause from JFeedParser::processElement (joomla#7961)
  CLEANING-JDataSet (joomla#7947)
  CLEANING-JAdapter (joomla#6679)
  Same  treatment as JArchiveBzip2 and JArchiveGzip (joomla#6515)
  Cleaning up JArchiveBzip2 (joomla#6495)
  Removed the nested conditional switch construct (joomla#6338)
  add edit tooltip to modules (joomla#10295)
  New installer plugins: remove the dot in the plugin name and other language review (joomla#10299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants