Add a retry button on webinstaller

[dgrammatiko]

For more info please check #5233

Testing

Make sure you have web installer installed.
Apply patch
Close your wifi/lan so no inernet connection exists
Go to web installer and wait till the fail message appears (20sec!)
press retry => the page should refresh

[dgrammatiko]

Adds a retry button in error message on webinstaller:

[wilsonge]

I don't like that we're putting the button html markup into language strings :( but at the same time i can see it's done for several other web installer language strings so I guess we should probably keep things consistent for now and change them en-masse later

[dgrammatiko]

I also don’t like the rude reload here but the way the script is written an alternative needs some major changes there. Unhappy with the end result, but at least now you get an option redo the call if something goes wrong, or no internet connection

[zero-24]

@DGT41

hmm i can't produce the error message.

what i do

• install clean staging
• install webinstaller
• install patchtester
• apply your patch
• disable internt
• try to access the webinstaller
• it hangs but after ca. 20 seconds it dont show me your message it show the normal Interface the don't update if i what to change the category.

[dgrammatiko]

Can you make a print screen of the message you re getting?

[zero-24]

@DGT41 it was a cache issue. With a other Browser the message appears and the retry button works.

@test success

[dgrammatiko]

@zero-24 Try in another browser. The key point is that you should NOT allow web installer to run initially because then the request is cached! So once the web installer gets installed you have to click somewhere or close the tab. then close your internet and go back…
The cached data is another think that we need to handle gracefully...

[dgrammatiko]

@zero-24 can you test #5255? I would really appreciated!!

[infograf768]

Folks, I would really prefer we do this in the plugin.

1. in webinstaller.php, method getChanges()
   add line 192

$retry = '<a class="btn btn-danger" onclick="location.reload();">' . JText::_('COM_INSTALLER_WEBINSTALLER_INSTALL_RETRY') . '</a>';

then change lines 209 and 236 to use a sprintf

<a class="close" data-dismiss="alert">×</a><?php echo JText::sprintf('COM_INSTALLER_WEBINSTALLER_INSTALL_WEB_LOADING_ERROR', $retry); ?>

Lang strings would be:
COM_INSTALLER_WEBINSTALLER_INSTALL_RETRY="Retry" // new
COM_INSTALLER_WEBINSTALLER_INSTALL_WEB_LOADING_ERROR="Cannot connect to the Joomla! server. Please try again later. %s" // variable added.

This would make it easier for TTs.

[Bakual]

I agree with George that it's not nice to have code within language strings. If anything they should be injected and not hardcoded into the translation string.

Maybe stupid question but do we really need a retry button? Each browser already has a button to reload the page. Imho the difference isn't big between reloading only the webinstaller or reloading the whole page.

[beat]

Agree with @Bakual : If really needed to handhold web-browser beginners (but are such people even Joomla super-admins?): Just add text " (Reload page to retry)".

Second question: Did this case even happen ? The whole AppStore is served through a redundant high-availablity high-performance CDN, so that downtimes are really very rare server-side. So the real happening of this is for people not connected to the Internet. And for those the error message seems clear enough to me.

And the main issue in that case is getting fixed by joomla-extensions/install-from-web-client#7 imho.

So do we still need this button in real situations ?

[dgrammatiko]

I am closing this one, since the functionality offered here is exists already in all browsers. Lets not complicate the things too much, @beat is right:

but are such people even Joomla super-admins?