Skip to content

[6.0] Fix EmptyState does not work for views extend from ListView#46079

Merged
softforge merged 1 commit intojoomla:6.0-devfrom
joomdonation:fix_emptystate_listview
Sep 12, 2025
Merged

[6.0] Fix EmptyState does not work for views extend from ListView#46079
softforge merged 1 commit intojoomla:6.0-devfrom
joomdonation:fix_emptystate_listview

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

There is a small typo in ListView class makes EmptyState feature is not working anymore for any views extends from ListView. This PR just fixes that typo

Testing Instructions

  • Use Joomla 6
  • Access to Components -> Banners -> Banners to see Banners management screen
  • Delete all existing banners (if there were banners created before)

Actual result BEFORE applying this Pull Request

emptystate layout is not used as expected, you see something like the attached screenshot

normal_layout

Expected result AFTER applying this Pull Request

emptystate layout is used. You see emptystate layout like in the attached screenshot

empty_state_layout

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title Fix EmptyState does not work for views extend from ListView [6.0] Fix EmptyState does not work for views extend from ListView Sep 12, 2025
@richard67 richard67 added the bug label Sep 12, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on b5a621e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46079.

Copy link
Member

@richard67 richard67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core comes from #45521 for 6.0-dev, so the change is correctly made for 6.0-dev.

@richard67
Copy link
Member

I have tested this item ✅ successfully on b5a621e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46079.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46079.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 12, 2025
@softforge softforge merged commit 2a4db3b into joomla:6.0-dev Sep 12, 2025
31 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 12, 2025
@softforge softforge added this to the Joomla! 6.0.0 milestone Sep 12, 2025
@softforge
Copy link
Contributor

thank you @joomdonation for your work on this and the testers for their diligence

@joomdonation joomdonation deleted the fix_emptystate_listview branch September 12, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants