[6.0] Improve ListView toolbar & components

[bembelimen]

Pull Request for Issue # .

Summary of Changes

This PR enhances the ListView class to:

• have the modern toolbar respecting all the permissions
• handle errors in a way, that the view does not crash
• handle empty list behaviour

It updates the following core views:

• ActionLogs view
• Banners view
• Contacts view
• Modules view

as they're very straight forward

Testing Instructions

For testing this you have to check the 4 views mentioned above. It's important to play around with the component permission, e.g. remove "create" permissions and see if in old and in new the same buttons are visible.

Also test with super user account and without if the buttons of the components are still the same with the same behaviour.

Also delete all the items in the component to see, that the empty state behaviour is the same.

Expected result AFTER applying this Pull Request

Toolbars behaves the same

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[exlemor]

@bembelimen, I wish I had good news...

When the PR is applied (6.0 nightly from this afternoon), the New and Actions button are NON functional on Banners, Contacts, Modules, ... yet if remove the Patch, they work perfectly fine... ;(

(for the ActionsLog, the Delete buttons are clickable and the Warning window appears but it doesn't actually delete entries :/

Console: (could be cumulative errors from the Banners, Contacts, Modules screens to be clear)

)

(sorry)

[bembelimen]

@exlemor the problems were the conflicts, I fixed them and you can test again please. Thank you, really appreciate it.

[exlemor]

@exlemor the problems were the conflicts, I fixed them and you can test again please. Thank you, really appreciate it.

Hi @bembelimen, Benjamin,

When I try to turn on the PR via Patch Tester, I get this error message in Red:
The file marked for modification does not exist: phpstan-baseline.neon

Trying to apply it to a nightly of "‎6.0.0-alpha4-dev", I installed yesterday.

:( (sorry)

[brianteeman]

@exlemor that is expected as that file is not part of the distributed Joomla. You really need to learn how to use git and then you wont have these problems

[exlemor]

I have tested this item ✅ successfully on 9673cb8

I have tested this successfully - thanks for the hard word and the fixes @bembelimen!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45521.}

[Bodge-IT]

I have tested this item ✅ successfully on 9673cb8

Tested 4 views across 3 users with diff perms. I couldn't break it but learned a ton about permissions.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45521.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45521.}

[softforge]

Thank you for your work on this @bembelimen and the testers