Skip to content

[6.0] No htmlhelper for js#45925

Merged
softforge merged 8 commits intojoomla:6.0-devfrom
dgrammatiko:6.0-dev/no-htmlhelper-for-js
Aug 30, 2025
Merged

[6.0] No htmlhelper for js#45925
softforge merged 8 commits intojoomla:6.0-devfrom
dgrammatiko:6.0-dev/no-htmlhelper-for-js

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Aug 16, 2025

Pull Request for Issue # .

Summary of Changes

  • replace HTMLHelper::_('behavior.xxx'); with the WAM counterpart as it exists in all the function of HTMLHelper::behavior comments:
    * Example: Factory::getApplication()->getDocument()->getWebAssetManager()->useScript('core');

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

everything works

Expected result AFTER applying this Pull Request

Everything works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

@dgrammatiko Please check in your changes on GitHub where PHPstan reports issues: https://github.com/joomla/joomla-cms/pull/45925/files and fix them. They are all Call to deprecated method getDocument() of class Joomla\CMS\Factory. Thanks in advance.

@richard67 richard67 requested a review from laoneo August 16, 2025 14:27
@richard67
Copy link
Member

@dgrammatiko Is this PR here still needed now after #45000 has been merged?

@dgrammatiko
Copy link
Contributor Author

The installation parts were overlapping but there are few more that are still to get into wam

@richard67
Copy link
Member

The installation parts were overlapping but there are few more that are still to get into wam

@dgrammatiko Yes, I've just noticed. Was trying to solve the conflicts. Will do that now.

@dgrammatiko dgrammatiko force-pushed the 6.0-dev/no-htmlhelper-for-js branch from 67bedd6 to 06e4d86 Compare August 17, 2025 09:14
@dgrammatiko
Copy link
Contributor Author

I was faster but thanks

@richard67
Copy link
Member

@dgrammatiko
Copy link
Contributor Author

I see Exception: Failed to start application but have no clue why?

@richard67
Copy link
Member

I see Exception: Failed to start application but have no clue why?

Me neither. I've restarted jobs, maybe it was a temporary glitch. If it fails again it needs to check in a local development environment to build and make a new installation.

@dgrammatiko dgrammatiko force-pushed the 6.0-dev/no-htmlhelper-for-js branch from f258403 to 74078ff Compare August 17, 2025 11:52
@dgrammatiko
Copy link
Contributor Author

@richard67 tests fixed (by removing irrelevant deprecated call replacements)

@richard67
Copy link
Member

@dgrammatiko Unfortunately 6.0.0-beta1 has already been prepared. But I am sure we will get this PR ready for 6.0.0-beta2.

@dgrammatiko
Copy link
Contributor Author

That’s fine I didn’t expect it to be merged immediately

@exlemor
Copy link

exlemor commented Aug 18, 2025

I have tested this item ✅ successfully on 8c9a17f

I have successfully tested this.

To be clear, I tested Administrator and Site Modules, Site and Administrator Templates settings, Custom Fields, Articles, - reading, changing etc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45925.

@bembelimen bembelimen added the bug label Aug 20, 2025
@exlemor exlemor added the PBF Pizza, Bugs and Fun label Aug 23, 2025
@rbuelund
Copy link

I have tested this item ✅ successfully on 8c9a17f

Tested on articles, modules, templates. Everything works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45925.

@richard67 richard67 removed PBF Pizza, Bugs and Fun bug labels Aug 23, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45925.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2025
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Aug 23, 2025
@richard67 richard67 added the bug label Aug 23, 2025
@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 30, 2025
@softforge softforge merged commit 2642ceb into joomla:6.0-dev Aug 30, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 30, 2025
@softforge
Copy link
Contributor

thank you @dgrammatiko and all the testers

@dgrammatiko dgrammatiko deleted the 6.0-dev/no-htmlhelper-for-js branch August 30, 2025 07:27
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Sep 2, 2025
* Remove `HTMLHelper::_('behavior..xxx);`

* Update Grid.php

* don’t use deprecated fn

* order

* z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PBF Pizza, Bugs and Fun PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants