[6.0] Use WebAsset for installation#45000
Conversation
Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>
|
This pull request has been automatically rebased to 6.0-dev. |
|
Could you clarify the testing instructions? Is this one where you have to download the code with the patch applied and then do a new Joomla install? I have never done one of those so will probably leave it to others to test. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000. |
To use the patch tester its required to have an installed Joomla instance. To test this PR you need the installation application -> patch tester not working |
|
The old and new line is not needed at all as we already load the validate script in the main template file |
|
As @brianteeman says, the ines can be removed completely. |
Done. Didn't notice that it was already loaded. |
|
I have tested this item ✅ successfully on df10f14 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000. |
|
I have tested this item ✅ successfully on df10f14 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000. |
|
Thanks @heelc29 for your work on this and thanks @brianteeman and @exlemor for testing |
Summary of Changes
Use WebAssets in Joomla installation template
Testing Instructions
check if
/media/system/js/fields/validate.min.jsis loaded when install joomlaActual result BEFORE applying this Pull Request
HTMLHelper is used
joomla-cms/libraries/src/HTML/Helpers/Behavior.php
Lines 64 to 66 in 027892a
Expected result AFTER applying this Pull Request
WebAssetManager is used in main template file
joomla-cms/installation/template/index.php
Line 23 in 027892a
Link to documentations
Please select: