Skip to content

[6.0] Use WebAsset for installation#45000

Merged
Bodge-IT merged 14 commits intojoomla:6.0-devfrom
heelc29:5.3/installation-template
Aug 16, 2025
Merged

[6.0] Use WebAsset for installation#45000
Bodge-IT merged 14 commits intojoomla:6.0-devfrom
heelc29:5.3/installation-template

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Feb 24, 2025

Summary of Changes

Use WebAssets in Joomla installation template

Testing Instructions

check if /media/system/js/fields/validate.min.js is loaded when install joomla

Actual result BEFORE applying this Pull Request

HTMLHelper is used

* @deprecated 4.0 will be removed in 6.0
* Use the webasset manager instead
* Example: Factory::getApplication()->getDocument()->getWebAssetManager()->useScript('form.validate');

Expected result AFTER applying this Pull Request

WebAssetManager is used in main template file

->useScript('form.validate')

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

Co-Authored-By: Richard Fath <richard67@users.noreply.github.com>
@HLeithner HLeithner changed the base branch from 5.3-dev to 6.0-dev March 4, 2025 17:18
@HLeithner HLeithner requested a review from rdeutz as a code owner March 4, 2025 17:18
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 6.0-dev.

@HLeithner HLeithner changed the title [5.3] Use WebAsset for installation [6.0] Use WebAsset for installation Mar 4, 2025
@rdeutz rdeutz removed the PR-5.3-dev label Mar 5, 2025
@ceford
Copy link
Contributor

ceford commented Jun 2, 2025

Could you clarify the testing instructions? Is this one where you have to download the code with the patch applied and then do a new Joomla install? I have never done one of those so will probably leave it to others to test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

@heelc29
Copy link
Contributor Author

heelc29 commented Jun 2, 2025

Could you clarify the testing instructions? Is this one where you have to download the code with the patch applied and then do a new Joomla install? I have never done one of those so will probably leave it to others to test.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

To use the patch tester its required to have an installed Joomla instance. To test this PR you need the installation application -> patch tester not working
Its better to use the prebuild package or checkout the git branch (needs composer/npm ...)

@brianteeman
Copy link
Contributor

The old and new line is not needed at all as we already load the validate script in the main template file

->useScript('form.validate')

@chmst
Copy link
Contributor

chmst commented Aug 11, 2025

As @brianteeman says, the ines can be removed completely.

@chmst chmst added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Aug 11, 2025
@heelc29
Copy link
Contributor Author

heelc29 commented Aug 12, 2025

The old and new line is not needed at all as we already load the validate script in the main template file

As @brianteeman says, the ines can be removed completely.

Done. Didn't notice that it was already loaded.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on df10f14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

@exlemor
Copy link

exlemor commented Aug 16, 2025

I have tested this item ✅ successfully on df10f14

I have tested this successfully with Phil and Gary in attendance ;) Thanks @heelc29!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

@richard67 richard67 added Updates Requested Indicates that this pull request needs an update from the author and should not be tested. and removed Updates Requested Indicates that this pull request needs an update from the author and should not be tested. labels Aug 16, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45000.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Aug 16, 2025
@Bodge-IT Bodge-IT merged commit a85902f into joomla:6.0-dev Aug 16, 2025
77 of 86 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@Bodge-IT
Copy link
Contributor

Thanks @heelc29 for your work on this and thanks @brianteeman and @exlemor for testing

@richard67 richard67 mentioned this pull request Aug 17, 2025
4 tasks
@richard67 richard67 added this to the Joomla! 6.0.0 milestone Aug 17, 2025
@heelc29 heelc29 deleted the 5.3/installation-template branch November 1, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.