Skip to content

[5.4] Update deleted files in script.php for the upcoming 5.4.0-beta1 (2)#45893

Merged
muhme merged 2 commits intojoomla:5.4-devfrom
richard67:5.4-dev-deleted-files-2025-08-12
Aug 12, 2025
Merged

[5.4] Update deleted files in script.php for the upcoming 5.4.0-beta1 (2)#45893
muhme merged 2 commits intojoomla:5.4-devfrom
richard67:5.4-dev-deleted-files-2025-08-12

Conversation

@richard67
Copy link
Member

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in script.php to the latest changes in the 5.4-dev branch, which are the deleted files resulting from following PRs:

Testing Instructions

Code review. Check the listed PRs for deleted files and verify that it matches the files being added by this PR to the list.

Or if you want to make a real test:

Update a 5.4.0-alpha3 to the latest 5.4 nightly build for the actual result, and update a 5.4.0-alpha3 to the patched update package or custom update URL created by drone for this PR for the expected result.

Actual result BEFORE applying this Pull Request

The files added by this PR to the list are still there after an update from 5.4.0-alpha3 to 5.4-dev nightly build, however they would not be there when making a new installation with that nightly build.

Expected result AFTER applying this Pull Request

The files added by this PR to the list are deleted after an update from 5.4.0-alpha3 to the patched package of this PR.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Copy link
Contributor

@muhme muhme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes by:

git clone https://github.com/joomla/joomla-cms
cd joomla-cms
git checkout dbe1582 # last update deleted files PR #45832
git merge origin/5.4-dev
git diff --name-status dbe1582..HEAD | grep '^D'

✅ Results exactly with the same 3 added files

@muhme muhme merged commit d1bb7e6 into joomla:5.4-dev Aug 12, 2025
40 checks passed
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 12, 2025
@muhme
Copy link
Contributor

muhme commented Aug 12, 2025

Thank you.

@richard67 richard67 deleted the 5.4-dev-deleted-files-2025-08-12 branch August 12, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants