Skip to content

[5.4] Convert site mod_login to service provider#45835

Merged
muhme merged 22 commits intojoomla:5.4-devfrom
joomlaweby:mod_login
Aug 6, 2025
Merged

[5.4] Convert site mod_login to service provider#45835
muhme merged 22 commits intojoomla:5.4-devfrom
joomlaweby:mod_login

Conversation

@joomlaweby
Copy link
Contributor

Summary of Changes

Converts the site login module to service provider.

Testing Instructions

  1. Make sure you have site module mod_login published
  2. You should see module output
  3. Try also to be logged-in/out
mod_login_site

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Aug 4, 2025

I have tested this item ✅ successfully on a9d3b12

I have successfully tested this - nice work @joomlaweby - I don't know how many more of these need converting to service provider, but keep 'em coming ;) I'll gladly test them ALL :) Cheers.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

@RickR2H
Copy link
Member

RickR2H commented Aug 5, 2025

I have tested this item ✅ successfully on a9d3b12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

@RickR2H
Copy link
Member

RickR2H commented Aug 5, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 5, 2025
@joomlaweby
Copy link
Contributor Author

I have tested this item ✅ successfully on a9d3b12I have successfully tested this - nice work @joomlaweby - I don't know how many more of these need converting to service provider, but keep 'em coming ;) I'll gladly test them ALL :) Cheers.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

I think there are 2 more modules...I've got them prepared :-)

@richard67
Copy link
Member

I think there are 2 more modules...I've got them prepared :-)

@joomlaweby Would be good to get them ready and tested before the end of next week when we will build our packages for Beta 1.

@richard67
Copy link
Member

RTC is still valid, commits after that were just clean branch updates and code style (removal of empty line).

@muhme
Copy link
Contributor

muhme commented Aug 6, 2025

✅ Final test before merge, with JBT graft Joomla_5.4.0-alpha4-dev+pr.45835-Development-Full_Package.zip

  • Tested with Firefox, Safari, Chrome and Edge
  • Created user with only Editor rights, logged in with admin and editor
  • Tested forgot your password and forgot your user name
  • Tested with and without remember me after browser restart
  • Tested disabling title, pre- and post-text
  • Installed German language paket and switch to German as default language, checked login form in German
  • Checked logs/error.php for logged login failures
  • Enabled user registration, checked link is working

@muhme muhme merged commit aa3dad7 into joomla:5.4-dev Aug 6, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 6, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 6, 2025
@muhme
Copy link
Contributor

muhme commented Aug 6, 2025

Thank you @joomlaweby for your contribution. Thank you @exlemor and @RickR2H for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants