Skip to content

[5.3] phpstan-baseline.neon should not be distributed#45730

Merged
muhme merged 3 commits intojoomla:5.3-devfrom
heelc29:5.3/package/phpstan-baseline
Jul 15, 2025
Merged

[5.3] phpstan-baseline.neon should not be distributed#45730
muhme merged 3 commits intojoomla:5.3-devfrom
heelc29:5.3/package/phpstan-baseline

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Jul 14, 2025

Follow up Pull Request for #45666

Summary of Changes

phpstan-baseline.neon should not be distributed

Testing Instructions

check content of install package

Actual result BEFORE applying this Pull Request

file is present
image

Expected result AFTER applying this Pull Request

file is not present

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@heelc29 heelc29 requested a review from rdeutz as a code owner July 14, 2025 18:01
@heelc29 heelc29 changed the title 5.3] phpstan-baseline.neon should not be distributed [5.3] phpstan-baseline.neon should not be distributed Jul 14, 2025
@richard67
Copy link
Member

I have tested this item ✅ successfully on 57e5cd0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45730.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 57e5cd0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45730.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45730.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 15, 2025
@muhme
Copy link
Contributor

muhme commented Jul 15, 2025

I have tested this item ✅ successfully on 74d1d2f

Final test before merge with JBT and current 5.3-dev

  • Before applying the patch the file phpstan-baseline.neon is included in ZIP, after applying the PR not.
php build/build.php --remote=HEAD
zipinfo -1 build/tmp/packages/Joomla_5.3.3-dev-Development-Full_Package.zip | grep phpstan-baseline.neon

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45730.

@muhme muhme merged commit fd96379 into joomla:5.3-dev Jul 15, 2025
32 of 34 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 15, 2025
@muhme muhme added this to the Joomla! 5.3.3 milestone Jul 15, 2025
@muhme
Copy link
Contributor

muhme commented Jul 15, 2025

Thank you @heelc29 and @richard67.

@heelc29 heelc29 deleted the 5.3/package/phpstan-baseline branch July 15, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments