Merged
Conversation
rdeutz
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst and
laoneo
as code owners
Member
|
The thing is that it also fails the whole PR when issues are fixed and are not part of the baseline anymore. Since we plan to fix lots of issues in 6.0 in regards to errors and JFactory in the near future, I'm hesitant to add this now. |
Contributor
Author
|
I don't think it will fail when you fix things. But the amount of messages makes it close to impossible to find a new thing. |
Member
|
Do we need to exclude this from the Joomla build? |
Member
I think so. |
Member
Has been done in 5.3-dev with PR #45730 and will be merged all the way up, so nothing to do here. |
richard67
approved these changes
Jul 16, 2025
4 tasks
Contributor
|
Thanks @RobertDeutz & @richard67. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR changes the behaviour of the CI System. We use PHPStan but ignore the failue of it. This is not the best option for further development. PHPStan has a baseline option and with this file it allows to ignore current failures. But it will still fail when new failures are added to the system. This doesn't make the current code better but makes sure it doesn't get wrose.
Testing Instructions
After this change the build should be green even the phpstan step.