Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented May 11, 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update in script.php to the latest changes in the 6.0-dev branch since the last PR of this kind for that branch, which was #45038 . In details these changes are:

In addition, it adds exceptions for the files and folders which belong to the Joomla 5 Backward Compatibility plugin to the deleted_file_check.php script so that these folders will not be deleted by the "deleteUnexistingFiles" method in script.php, as these folders will already be deleted by the "uninstallExtensions" method in script.php.

Finally, it adds exceptions for the "administrator/language/en-GB/guidedtours.joomla_whatsnew_5_4.ini" and "administrator/language/en-GB/guidedtours.joomla_whatsnew_5_4_steps.ini" files to the deleted_file_check.php script, as we do not want to deletedf these files on update, see also PR #45512 .

Testing Instructions

Code review, or if you want to do a real test:

Update a recent 5.4-dev nightly build to the latest 6.0-dev nightly build to get the actual result, and update a recent 5.4-dev nightly build to the patched package created by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

After an update from a recent 5.4-dev nightly build to the latest 6.0-dev nightly build, the files and the folder added by this PR to the lists in script.php are still present.

Expected result AFTER applying this Pull Request

After an update from a recent 5.4-dev nightly build to the patched package created by Drone for this PR, the files and the folder added by this PR to the lists in script.php have been deleted.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 marked this pull request as ready for review May 11, 2025 16:59
@richard67 richard67 requested a review from rdeutz as a code owner May 25, 2025 22:39
@Bodge-IT
Copy link
Contributor

I have tested this item ✅ successfully on 50ec078

Tested with latest nightly 5.4alpha1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45462.

@softforge softforge added this to the Joomla! 6.0.0 milestone May 26, 2025
@softforge softforge merged commit f0092bb into joomla:6.0-dev May 26, 2025
3 of 4 checks passed
@softforge
Copy link
Contributor

A big thankyou to @richard67 for the work in doing this and @Bodge-IT for testing at short notice on his holiday

@richard67 richard67 deleted the 6.0-dev-deleted-files-and-folders-2025-05-11 branch May 26, 2025 10:26
@richard67
Copy link
Member Author

@Bodge-IT Thanks for testing. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants