-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.3] Revert update of typo3/phar-stream-wrapper and deprecate it #45255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested this item ✅ successfully on 7d91552 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45255. |
|
I have tested this item ✅ successfully on 5529ce0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45255. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45255. |
|
@Hackwar Could you regenerate the checksum in the composer.lock file? It seems since the last branch update it doesn't match anymore as that file has also been changed in the base branch meanwhile. |
|
I think I could fix it |
@rdeutz Yes, looks ok now in Drone composer step. |
Summary of Changes
#44808 updated our dependency on the typo3/phar-stream-wrapper to the next major version, being under the impression, that the package is needed and that the updates would be backwards compatible. This actually seems to not be correct and (as unlikely as it is) when other code extends this, it would throw errors. It also turns out, that the whole package is not needed anymore, since the underlying issue has been solved in PHP 8.0 already. So this package isn't needed anymore. The plan is to deprecate it now and then to remove it in 6.0.
Testing Instructions
Before and after applying the PR, there shouldn't be any changes.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Deprecate TYPO3/phar-stream-wrapper Manual#436
No documentation changes for manual.joomla.org needed