Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 31, 2025

Summary of Changes

#44808 updated our dependency on the typo3/phar-stream-wrapper to the next major version, being under the impression, that the package is needed and that the updates would be backwards compatible. This actually seems to not be correct and (as unlikely as it is) when other code extends this, it would throw errors. It also turns out, that the whole package is not needed anymore, since the underlying issue has been solved in PHP 8.0 already. So this package isn't needed anymore. The plan is to deprecate it now and then to remove it in 6.0.

Testing Instructions

Before and after applying the PR, there shouldn't be any changes.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Deprecate TYPO3/phar-stream-wrapper Manual#436

  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner added b/c break This item changes the behavior in an incompatible why. HEADS UP Release Blocker and removed b/c break This item changes the behavior in an incompatible why. HEADS UP labels Mar 31, 2025
@laoneo
Copy link
Member

laoneo commented Mar 31, 2025

I have tested this item ✅ successfully on 7d91552

Despite the dependency got readded, there were no PHP 8.4 deprecation's shown on the first page load.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45255.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5529ce0

didnt see any php errors with 8.4 running the system tests


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45255.

@QuyTon
Copy link
Contributor

QuyTon commented Apr 1, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45255.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2025
@richard67
Copy link
Member

@Hackwar Could you regenerate the checksum in the composer.lock file? It seems since the last branch update it doesn't match anymore as that file has also been changed in the base branch meanwhile.

@rdeutz
Copy link
Contributor

rdeutz commented Apr 2, 2025

I think I could fix it

@richard67
Copy link
Member

I think I could fix it

@rdeutz Yes, looks ok now in Drone composer step.

@rdeutz rdeutz enabled auto-merge (squash) April 2, 2025 17:28
@rdeutz rdeutz merged commit b3f9f32 into joomla:5.3-dev Apr 2, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2025
@richard67 richard67 added this to the Joomla! 5.3.0 milestone Apr 2, 2025
@Hackwar Hackwar deleted the 5.3-typo3pharwrapper branch June 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants